Date: Sun, 16 Oct 2011 15:26:21 GMT From: Manolis Kiagias <manolis@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: bin/161711: [patch] bsdinstall(8) does not quote the keymap setting in rc.conf Message-ID: <201110161526.p9GFQLPj002276@red.freebsd.org> Resent-Message-ID: <201110161530.p9GFUQjO057951@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 161711 >Category: bin >Synopsis: [patch] bsdinstall(8) does not quote the keymap setting in rc.conf >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 16 15:30:25 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Manolis Kiagias >Release: 9.0-BETA3 >Organization: >Environment: >Description: When selecting a keyboard map during installation with bsdinstall, the relevant rc.conf entry is written without quotes. While quotes are not necessary, all entries have had them till now (sysinstall always quoted settings) and it also seems every other bsdinstall entry is quoted. Apparently the problem lies with the kbdmap program called from bsdinstall. >How-To-Repeat: Select a keyboard map during installation. Look at the rc.conf entry after installation. >Fix: Apply the following patch to kbdmap.c Patch attached with submission follows: --- kbdmap.c.original 2011-10-16 18:12:55.000000000 +0300 +++ kbdmap.c 2011-10-16 18:14:12.000000000 +0300 @@ -289,7 +289,7 @@ if (!x11) system(kbd_cmd); - fprintf(stderr, "keymap=%s\n", km->keym); + fprintf(stderr, "keymap=\"%s\"\n", km->keym); free(kbd_cmd); } >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110161526.p9GFQLPj002276>