Date: Thu, 25 Feb 2021 09:35:13 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Adriaan de Groot <adridg@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files Message-ID: <20210225093513.GA59@FreeBSD.org> In-Reply-To: <20210225091804.qip5ehkragajibmg@aching.in.mat.cc> References: <202102242045.11OKjEpT075754@repo.freebsd.org> <20210225091804.qip5ehkragajibmg@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote:
> On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote:
> > - @${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL}
> > + # Drop all leading spaces in the script, to minify
> > + @${REINPLACE_CMD} 's/^ *//' ${PKGINSTALL} ${PKGDEINSTALL}
>
> [[:space:]] works with all versions.
Yes please. Not just it's more robust, it also expresses the intention
better, as we probably want to trim *any* unnecessary whitespace, not
some particular character.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210225093513.GA59>