Date: Wed, 13 Dec 2000 17:43:12 -0800 (PST) From: Matt Dillon <dillon@earth.backplane.com> To: Alfred Perlstein <bright@wintelcom.net> Cc: Kirk McKusick <mckusick@mckusick.com>, arch@FreeBSD.ORG, net@FreeBSD.ORG Subject: Re: patch to cleanup inflight desciptor handling. Message-ID: <200012140143.eBE1hCx90268@earth.backplane.com> References: <200012131852.KAA17423@beastie.mckusick.com> <200012132106.eBDL6Sg86570@earth.backplane.com> <20001213141917.Q16205@fw.wintelcom.net> <20001213145341.S16205@fw.wintelcom.net> <20001213153649.T16205@fw.wintelcom.net> <200012140125.eBE1Pbi89951@earth.backplane.com> <20001213173103.B16205@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
:> No waste at all, Alfred, the file descriptor passing code had been
:
:Are you saying the code in place is broken? If so I'll spend some
:time looking at it and the Linux implementation to figure if at
:least one of us gets it right and try to find some sort of solution.
No, *had*, not *has*. It isn't broken, just inefficient in certain
cases due to the brute-force GC.
:Obviously the easiest way would be to disallow passing of any
:descriptors that have descriptors in thier socketbuffers.
:
:Since almost no one uses this code, and I hardly see a reason for
:allowing that type of operation (passing af_unix fds with fds in
:flight) it might be a good idea to just disallow that sort of
:operation.
:
:It would definetly simplify and probably speed up the code.
There's no reason to disallow that. Besides, any socket
can be listen()'d after having been queued, so you aren't really
preventing anything.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012140143.eBE1hCx90268>