Date: Fri, 12 Feb 2010 13:25:22 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: freebsd-ipfw@FreeBSD.org, svn-src-all@freebsd.org Subject: Re: svn commit: r200855 - in head/sys: net netgraph netinet netinet/ipfw Message-ID: <4B752C92.30705@yandex.ru> In-Reply-To: <200912221901.nBMJ1mXQ072673@svn.freebsd.org> References: <200912221901.nBMJ1mXQ072673@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22.12.2009 22:01, Luigi Rizzo wrote: > Author: luigi > Date: Tue Dec 22 19:01:47 2009 > New Revision: 200855 > URL: http://svn.freebsd.org/changeset/base/200855 > > Log: > merge code from ipfw3-head to reduce contention on the ipfw lock > and remove all O(N) sequences from kernel critical sections in ipfw. > > In detail: > > 1. introduce a IPFW_UH_LOCK to arbitrate requests from > the upper half of the kernel. Some things, such as 'ipfw show', > can be done holding this lock in read mode, whereas insert and > delete require IPFW_UH_WLOCK. > > The only (very small) regression is on dynamic rule lookup and this will > be fixed in a day or two, without changing the userland/kernel ABI > > Supported by: Valeria Paoli > MFC after: 1 month > > Modified: > head/sys/netinet/ipfw/ip_fw_sockopt.c Hi, Luigi. This commit also broke `ipfw set show` operation. It always show all sets enabled, because IP_FW_GET command gets small buffer and after calculating wanted size it returns back without copying anything. -- WBR, Andrey V. Elsukov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B752C92.30705>