Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Jun 2015 02:06:08 +0800
From:      Sunpoet Hsieh <sunpoet@sunpoet.net>
To:        Antoine Brodin <antoine@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r390588 - in head: net/luasocket textproc/luaexpat
Message-ID:  <CAMHz58TiYbRzxX5cBi%2BE9tKGwEn2hkvBwBcTLq11F5tNE8=oVg@mail.gmail.com>
In-Reply-To: <201506251653.t5PGrWUb082817@svn.freebsd.org>
References:  <201506251653.t5PGrWUb082817@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 26, 2015 at 12:53 AM, Antoine Brodin <antoine@freebsd.org>
wrote:

> Author: antoine
> Date: Thu Jun 25 16:53:31 2015
> New Revision: 390588
> URL: https://svnweb.freebsd.org/changeset/ports/390588
>
> Log:
>   Switch back to lua 5.1,  the two consumers of those ports
> (audio/lua51-mpd
>   and net-im/prosody) need it
>
>   Pointy hat:   sunpoet
>
> Modified:
>   head/net/luasocket/Makefile
>   head/textproc/luaexpat/Makefile
>
> Modified: head/net/luasocket/Makefile
>
> ==============================================================================
> --- head/net/luasocket/Makefile Thu Jun 25 16:52:55 2015        (r390587)
> +++ head/net/luasocket/Makefile Thu Jun 25 16:53:31 2015        (r390588)
> @@ -16,7 +16,7 @@ GH_ACCOUNT=   diegonehab
>  GH_TAGNAME=    v3.0-rc1
>
>  MAKE_ARGS=     LUA_VER=${LUA_VER}
> -USES=          lua gmake pkgconfig
> +USES=          lua:51 gmake pkgconfig
>
>  CFLAGS+=       `pkgconf --cflags lua-${LUA_VER}`
>  LDFLAGS+=      -shared  `pkgconf --libs lua-${LUA_VER}`
>
> Modified: head/textproc/luaexpat/Makefile
>
> ==============================================================================
> --- head/textproc/luaexpat/Makefile     Thu Jun 25 16:52:55 2015
> (r390587)
> +++ head/textproc/luaexpat/Makefile     Thu Jun 25 16:53:31 2015
> (r390588)
> @@ -13,7 +13,7 @@ COMMENT=      LuaExpat is a SAX XML parser ba
>
>  LIB_DEPENDS=   libexpat.so:${PORTSDIR}/textproc/expat2
>
> -USES=          gmake lua
> +USES=          gmake lua:51
>  ALL_TARGET=    lib
>  CFLAGS+=       -DLUA_INT_LONG
>
>
>  <http://people.FreeBSD.org/~sunpoet/pgpkeys.txt>;
Hi,

Bapt done lots of work to convert USE_LUA to USES=lua.
IIRC, most of them are USES=lua:51.
We need to relax them to USES=lua if they work fine with lua52 or lua53.

In this case, they build fine with lua52 and lua53.
I think the correct fix should be:
- audio/lua51-mpd: replace USES=lua:51 with USES=lua (and rename this port
to lua-mpd).
- net-im/prosody: replace USES=lua:51 in security/luasec/Makefile with
USES=lua.

Can you revert this and change USES=lua:51 to USES=lua for audio/lua51-mpd
and security/luasec?
Thanks.

Regards,
sunpoet



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58TiYbRzxX5cBi%2BE9tKGwEn2hkvBwBcTLq11F5tNE8=oVg>