Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 9 Aug 2017 12:38:26 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        David Wolfskill <david@catwhisker.org>, "current@freebsd.org" <current@freebsd.org>, sjg@freebsd.org
Subject:   Re: Apparent race in buildworld (head/amd64, r322214 -> r322304)
Message-ID:  <87e123b5-c42c-e096-95cc-cd0c79228bb7@FreeBSD.org>
In-Reply-To: <20170809193537.GD1244@albert.catwhisker.org>
References:  <20170809120436.GY1244@albert.catwhisker.org> <689a8aa1-c8a3-a8e3-bc01-8bec5c212b41@FreeBSD.org> <20170809175724.GC1244@albert.catwhisker.org> <2d6ecd49-2bcc-0c24-8854-63079c0eef6b@FreeBSD.org> <20170809193537.GD1244@albert.catwhisker.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--jmuSWu8LC0T6aApucUXXWDtJq8bRNO3Qa
Content-Type: multipart/mixed; boundary="O4oQIBlntc20DbcddvucsK7L2WBvumtew";
 protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: David Wolfskill <david@catwhisker.org>,
 "current@freebsd.org" <current@freebsd.org>, sjg@freebsd.org
Message-ID: <87e123b5-c42c-e096-95cc-cd0c79228bb7@FreeBSD.org>
Subject: Re: Apparent race in buildworld (head/amd64, r322214 -> r322304)
References: <20170809120436.GY1244@albert.catwhisker.org>
 <689a8aa1-c8a3-a8e3-bc01-8bec5c212b41@FreeBSD.org>
 <20170809175724.GC1244@albert.catwhisker.org>
 <2d6ecd49-2bcc-0c24-8854-63079c0eef6b@FreeBSD.org>
 <20170809193537.GD1244@albert.catwhisker.org>
In-Reply-To: <20170809193537.GD1244@albert.catwhisker.org>

--O4oQIBlntc20DbcddvucsK7L2WBvumtew
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 8/9/2017 12:35 PM, David Wolfskill wrote:
> On Wed, Aug 09, 2017 at 12:22:20PM -0700, Bryan Drewery wrote:
>>> 	/usr/obj/usr/src/tmp/usr/bin/ld: cannot find -lgcc_s
>> ...=20
>>
>> This should fix it:
>> https://people.freebsd.org/~bdrewery/patches/gcc_s-install-race.diff
>>
>> The problem has consistently been, from your reports, that gcc_s is
>> being installed to WORLDTMP *while* something is trying to link to it.=

>=20
> Yeah, that doesn't seem like something that's likely to have
> deterministic results.
>=20
>> ...
>>> --- lib/libc++__L ---
>>> /usr/obj/usr/src/tmp/usr/bin/ld: cannot find -lgcc_s
>>>
>>> --- lib/libgcc_s__L ---^M                                            =
        =20
>> ...
>>> --- all_subdir_secure/lib/libcrypto/engines/libsureware ---^M        =
        =20
>>> /usr/obj/usr/src/tmp/usr/bin/ld: cannot find -lgcc_s^M               =
        =20
>>
>>
>>
>> By default 'install' unlinks the file and then copies over the new fil=
e.
>>  Using PRECIOUSLIB we get the -S flag to install which is atomic in it=
s
>> installation.
>>
>> Note the patch is not what I will commit. At Isilon we changed our
>> install to always use -S for library installation, but not to force sc=
hg
>> on.  I am considering making that change the default, to use -S for al=
l
>> libraries.
>=20
> From an (admittedly) naive perspective, it seems to me that enforcing
> "atomic installation" for file system objects that are to be used
> during the build (or install) makes more sense than firing and
> hoping for the best.  :-}
>=20

It also fixes some runtime crashes while concurrently running
installworld to a live system.  One that we ran into a lot was an NSS
module being used for user lookup that another concurrent install would
use while the module was being overwritten.  It would see a bogus file
during the install.

>> --=20
>> Regards,
>> Bryan Drewery
>>
>=20
> Thanks! :-)
>=20
> Peace,
> david
>=20


--=20
Regards,
Bryan Drewery


--O4oQIBlntc20DbcddvucsK7L2WBvumtew--

--jmuSWu8LC0T6aApucUXXWDtJq8bRNO3Qa
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJZi2SyAAoJEDXXcbtuRpfPT5EH/iximBBvbgblRl9du9xPO0vy
9ojHm6+hjg8MQs2KM5BBCtLKtfXy0h/CJy7jzwH7i6ZcKWDUSC1YZdUqiOidTMq9
7riJ+oKX/TUtRjDmLyxqKEuxI94OSx5Julxx0MNChbM1DL1/m5yIUrQJcmXWDTjo
7C+vTGmQwp4fKujB61qasxmlSxF19GRSwREVThkIpo8rw1xCTiNKxnxGKTPjHppk
3DFsNZ8U/dDhOKR9lIprHvaPlqVOcxs6CcgKzXEH8NF+oql4h9dxGByE5I6CJmI8
acMkkUdYG/jTgsF4YGKxVMwLb0dmTCZNYcwFY/V2CNzrUFXh/9ClqhBtWQWynlE=
=1W0A
-----END PGP SIGNATURE-----

--jmuSWu8LC0T6aApucUXXWDtJq8bRNO3Qa--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87e123b5-c42c-e096-95cc-cd0c79228bb7>