Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Feb 2017 05:29:33 +0000 (UTC)
From:      Jan Beich <jbeich@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r432988 - head/devel/alabastra/files
Message-ID:  <201702010529.v115TXGJ089176@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jbeich
Date: Wed Feb  1 05:29:33 2017
New Revision: 432988
URL: https://svnweb.freebsd.org/changeset/ports/432988

Log:
  devel/alabastra: unbreak with clang 4.0
  
  src/AlWinMain.cpp:164:35: error: ordered comparison between pointer and zero ('QListWidgetItem *' and 'int')
          if (ui.list_files->currentItem() > 0)
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  src/AlWinMain.cpp:722:16: error: ordered comparison between pointer and zero ('AlTextEdit *' and 'int')
          if (actualTxt > 0 && ui.list_files->currentItem() > 0)
              ~~~~~~~~~ ^ ~
  src/AlWinMain.cpp:722:52: error: ordered comparison between pointer and zero ('QListWidgetItem *' and 'int')
          if (actualTxt > 0 && ui.list_files->currentItem() > 0)
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  src/AlWinMain.cpp:731:16: error: ordered comparison between pointer and zero ('AlTextEdit *' and 'int')
          if (actualTxt > 0 && ui.list_files->currentItem() > 0)
              ~~~~~~~~~ ^ ~
  src/AlWinMain.cpp:731:52: error: ordered comparison between pointer and zero ('QListWidgetItem *' and 'int')
          if (actualTxt > 0 && ui.list_files->currentItem() > 0)
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  
  Reported by:	antoine (via exp-run)

Added:
  head/devel/alabastra/files/
  head/devel/alabastra/files/patch-src_AlWinMain.cpp   (contents, props changed)

Added: head/devel/alabastra/files/patch-src_AlWinMain.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/alabastra/files/patch-src_AlWinMain.cpp	Wed Feb  1 05:29:33 2017	(r432988)
@@ -0,0 +1,29 @@
+--- src/AlWinMain.cpp.orig	2007-10-13 11:06:35 UTC
++++ src/AlWinMain.cpp
+@@ -161,7 +161,7 @@ void AlWinMain::connectEditor( AlTextEdi
+ */
+ void AlWinMain::insertDateTime(){
+ 	QDateTime dt=QDateTime::currentDateTime();
+-	if (ui.list_files->currentItem() > 0)
++	if (ui.list_files->currentItem() != NULL)
+ 	actualTxt->textCursor().insertText(dt.toString(Qt::LocalDate));
+ };
+ 
+@@ -719,7 +719,7 @@ void AlWinMain::refresh()
+ */
+ void AlWinMain::cancella()
+ {
+-	if (actualTxt > 0 && ui.list_files->currentItem() > 0)
++	if (actualTxt != NULL && ui.list_files->currentItem() != NULL)
+ 	actualTxt->clear();
+ 	
+ };
+@@ -728,7 +728,7 @@ void AlWinMain::cancella()
+ */
+ void AlWinMain::insertComment()
+ {
+-	if (actualTxt > 0 && ui.list_files->currentItem() > 0)
++	if (actualTxt != NULL && ui.list_files->currentItem() != NULL)
+ 	actualTxt->textCursor().insertText(" /*********/ "
+ 									" /*       */ "		
+ 								   " /*********/ " );



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702010529.v115TXGJ089176>