Date: Wed, 19 Feb 2020 19:42:57 +0000 From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-feedback requested: [Bug 244235] x11/xkbcomp: Fix build with clang 10.0.0 Message-ID: <bug-244235-7141-EgfiLs5R6V@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-244235-7141@https.bugs.freebsd.org/bugzilla/> References: <bug-244235-7141@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-x11 mailing li= st <x11@FreeBSD.org> for maintainer-feedback: Bug 244235: x11/xkbcomp: Fix build with clang 10.0.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244235 --- Description --- Fix clang 10.0.0 errors: xkbcomp.c:228:37: error: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Werror,-Wstring-compare] if ((argv[i][0] !=3D '-') || (uStringEqual(argv[i], "-"))) ^~~~~~~~~~~~~~~~~~~~~~~~~~ ./utils.h:195:30: note: expanded from macro 'uStringEqual' #define uStringEqual(s1,s2) (uStringCompare(s1,s2)=3D=3DEqual) ^~~~~~~~~~~~~~~~~~~~~ ./utils.h:198:38: note: expanded from macro 'uStringCompare' (s1)!=3D(s2):strcmp(s1,s2)) ^ ~~~~ Don't attempt to do this macro trickery, and simply use strcmp instead, where it applies.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-244235-7141-EgfiLs5R6V>