Date: Mon, 3 May 2021 15:30:55 -0400 From: Allan Jude <allanjude@freebsd.org> To: Kevin Bowling <kevin.bowling@kev009.com>, Mark Johnston <markj@freebsd.org> Cc: dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org Subject: Re: git: 64881da47807 - main - ixgbe: Restore AIM support Message-ID: <295b05d0-58ba-6e04-6fbf-cb997c9ab112@freebsd.org> In-Reply-To: <CAK7dMtCRTHW5f9qe-ZPaRZGaoUGNoQvLFKeMQcrDesevghEQ4g@mail.gmail.com> References: <202105031755.143Htj33046938@gitrepo.freebsd.org> <CAK7dMtCRTHW5f9qe-ZPaRZGaoUGNoQvLFKeMQcrDesevghEQ4g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/3/2021 2:12 PM, Kevin Bowling wrote: > Should we enable this by default? My primary concern in the review is > not making things like this require expert tuning. If it is expected to > be necessary, which Gallatin@ makes a case for, let’s toggle it on by > default. > > On Mon, May 3, 2021 at 10:56 AM Mark Johnston <markj@freebsd.org > <mailto:markj@freebsd.org>> wrote: > > The branch main has been updated by markj: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=64881da478071431a2d9e62613997a5772c56cdf > <https://cgit.FreeBSD.org/src/commit/?id=64881da478071431a2d9e62613997a5772c56cdf>; > > commit 64881da478071431a2d9e62613997a5772c56cdf > Author: Sai Rajesh Tallamraju <stallamr@netapp.com > <mailto:stallamr@netapp.com>> > AuthorDate: 2021-05-03 17:45:00 +0000 > Commit: Mark Johnston <markj@FreeBSD.org> > CommitDate: 2021-05-03 17:47:14 +0000 > It looks like AIM was on by default in 11.x and earlier: hw.ix.enable_aim: 1 hw.igb.enable_aim: 1 So I think enabling it does make sense in light of Drew's comments about mbuf sorting only being useful in the face of something like AIM where there will be a sufficient number of mbufs to sort. -- Allan Jude
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?295b05d0-58ba-6e04-6fbf-cb997c9ab112>