Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 07 Jul 2014 19:41:25 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 191720] New: minor cut-and-paste error in pwd_mkdb
Message-ID:  <bug-191720-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191720

            Bug ID: 191720
           Summary: minor cut-and-paste error in pwd_mkdb
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: turingsboy@yahoo.com

There appears to be a cut-and-paste error in one spot in pwd_mkdb.
I am unsure of how it affects users, if it does at all.

Here is the patch:

--- pwd_mkdb.c.orig    2014-07-07 12:29:15.019698896 -0700
+++ pwd_mkdb.c    2014-07-07 12:30:08.125795430 -0700
@@ -341,21 +341,21 @@ main(int argc, char *argv[])
          * user.  When operating on `old format' databases, this
          * would result in applications `seeing' only the updated
          * entries.
          */
         key.data = verskey;
         key.size = sizeof(verskey)-1;
         data.data = &version;
         data.size = 1;
         if ((dp->put)(dp, &key, &data, 0) == -1)
             error("put");
-        if ((dp->put)(sdp, &key, &data, 0) == -1)
+        if ((sdp->put)(sdp, &key, &data, 0) == -1)
             error("put");
     }
     ypcnt = 0;
     data.data = (u_char *)buf;
     sdata.data = (u_char *)sbuf;
     key.data = (u_char *)tbuf;
     for (cnt = 1; scan(fp, &pwd); ++cnt) {
         if (!is_comment && 
             (pwd.pw_name[0] == '+' || pwd.pw_name[0] == '-')) {
             yp_enabled = 1;


By grepping the file, we can see that everywhere else in the file uses
sdp->put instead of dp->put:

$ grep put pwd_mkdb.c.orig | grep sdp
5:351:        if ((dp->put)(sdp, &key, &data, 0) == -1)
13:437:            if ((sdp->put)(sdp, &key, &sdata, method) == -1)
15:445:            if ((sdp->put)(sdp, &key, &sdata, method) == -1)
17:453:            if ((sdp->put)(sdp, &key, &sdata, methoduid) == -1)
21:464:                if ((sdp->put)(sdp, &key, &sdata, method) == -1)
29:527:            if ((sdp->put)(sdp, &key, &sdata, method) == -1)
31:535:            if ((sdp->put)(sdp, &key, &sdata, method) == -1)
33:543:            if ((sdp->put)(sdp, &key, &sdata, methoduid) == -1)
37:554:                if ((sdp->put)(sdp, &key, &sdata, method) == -1)
41:584:        if ((sdp->put)(sdp, &key, &data, method) == -1)
45:590:        if ((sdp->put)(sdp, &key, &data, method) == -1)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191720-8>