Date: Thu, 09 Jul 2015 22:27:40 -0400 From: "George Neville-Neil" <gnn@freebsd.org> To: "Peter Wemm" <peter@wemm.org> Cc: svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285336 - in head/sys: netipsec opencrypto Message-ID: <E82240DD-05F4-4CAD-B478-FF0948816FF0@freebsd.org> In-Reply-To: <15342729.MI2b1tqqeb@overcee.wemm.org> References: <201507091816.t69IGawf097288@repo.freebsd.org> <15342729.MI2b1tqqeb@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 3156 and 4880). --=_MailMate_E4AAF0D0-6D10-4223-AEFE-371759A562B3_= Content-Type: text/plain On 9 Jul 2015, at 18:26, Peter Wemm wrote: > On Thursday, July 09, 2015 06:16:36 PM George V. Neville-Neil wrote: >> Author: gnn >> Date: Thu Jul 9 18:16:35 2015 >> New Revision: 285336 >> URL: https://svnweb.freebsd.org/changeset/base/285336 >> >> Log: >> Add support for AES modes to IPSec. These modes work both in software >> only mode and with hardware support on systems that have AESNI >> instructions. >> >> Differential Revision: D2936 >> Reviewed by: jmg, eri, cognet >> Sponsored by: Rubicon Communications (Netgate) >> >> Modified: >> head/sys/netipsec/xform_ah.c >> head/sys/netipsec/xform_esp.c > >> @@ -953,6 +989,11 @@ esp_output_cb(struct cryptop *crp) >> case CRYPTO_SHA2_512_HMAC: >> alen = esph->hashsize/2; >> break; >> + case CRYPTO_AES_128_GMAC: >> + case CRYPTO_AES_192_GMAC: >> + case CRYPTO_AES_256_GMAC: >> + alen = esph->hashsize; >> + break; >> default: >> alen = AH_HMAC_HASHLEN; >> break; > > This introduces a LINT compile failure: > > /usr/src/sys/netipsec/xform_esp.c:992:9: error: use of undeclared identifier > 'CRYPTO_AES_128_GMAC' > case CRYPTO_AES_128_GMAC: > ^ > /usr/src/sys/netipsec/xform_esp.c:993:9: error: use of undeclared identifier > 'CRYPTO_AES_192_GMAC' > case CRYPTO_AES_192_GMAC: > ^ > /usr/src/sys/netipsec/xform_esp.c:994:9: error: use of undeclared identifier > 'CRYPTO_AES_256_GMAC' > case CRYPTO_AES_256_GMAC: > ^ > 3 errors generated. > --- xform_esp.o --- > Apologies, fixed in 285347. BTW The LINT conf in amd64 is ignored. Why? Best, George --=_MailMate_E4AAF0D0-6D10-4223-AEFE-371759A562B3_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlWfLZwACgkQYdh2wUQKM9LGAwCgw/bjdr417DbaTVE/K18WZDPl irMAnR9aEO714KNo8NMJ3nKd4CKIgB+w =fE+B -----END PGP SIGNATURE----- --=_MailMate_E4AAF0D0-6D10-4223-AEFE-371759A562B3_=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E82240DD-05F4-4CAD-B478-FF0948816FF0>