Date: Thu, 26 Jul 2018 06:44:08 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Yuri Victorovich <yuri@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r475335 - head/devel/liteide Message-ID: <20180726064408.GC77261@FreeBSD.org> In-Reply-To: <201807252025.w6PKPsxQ097871@repo.freebsd.org> References: <201807252025.w6PKPsxQ097871@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 25, 2018 at 08:25:54PM +0000, Yuri Victorovich wrote: > New Revision: 475335 > URL: https://svnweb.freebsd.org/changeset/ports/475335 > > Log: > devel/liteide: Update 33.3 -> 34 > > Replace QT4/QT5 options with flavors. > > ... > +FLAVORS= qt5 qt4 > +FLAVOR?= ${FLAVORS:[1]} Is this line needed in this case? > ... > +.if ${FLAVOR} == qt4 > +USES+= qt:4 > +USE_QT= corelib gui moc_build network rcc_build uic_build webkit xml > +PLIST_SUB+= QT4="" NO_QT4="@comment " > +.else > +USES+= qt:5 > +USE_QT= buildtools_build core gui network printsupport widgets xml > +PLIST_SUB+= QT4="@comment " NO_QT4="" > +.endif Because qt5 is default flavor, and you're checking for qt4 first (qt5 is in .else branch) and never for .if ${FLAVOR} == qt5. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180726064408.GC77261>