Date: Thu, 25 Feb 2021 12:50:05 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566529 - head/x11/foot Message-ID: <20210225115005.ebfocnpwupvnjubk@aching.in.mat.cc> In-Reply-To: <202102251130.11PBUM4M013317@repo.freebsd.org> References: <202102251130.11PBUM4M013317@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--6xngppuugy4zdy47
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Feb 25, 2021 at 11:30:22AM +0000, Jan Beich wrote:
> +post-patch: terminfo-patch
> +terminfo-patch:
> + @${REINPLACE_CMD} '/datadir/s/terminfo/site-&/' ${WRKSRC}/meson.build
This seems overengineered, there is no post-patch target in the
Makefile, so, why create a new target, and hook it up to a non existing
target, instead of just using a regular post-patch target?
If there is a good reason for that, it is not obvious, and the reason
needs to be documented in the Makefile.
--=20
Mathieu Arnold
--6xngppuugy4zdy47
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmA3juhfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgLp3A//cEXykoII3btGqNvwSenP220uzFjDyg+VEh5aWGsC69pG2Lxxer3dBemV
NmdHBDX8GK6nph9c8aDRtNvjbs6shwFcn/VOGlKHG5HUfw7WydP3h+abm1LviEIM
1Ls62zUmW71T2zFQFzlG03UviQsoIKEriU3yhdRv90PNAMCYv66/yzauiliklbzi
Oz2V4/vFN6O1RYxZ0qctGrq9jxAmoPSamddCIOQFjROlPAvpvucEbBe3XnaL32T3
34P/pIFeoa1hwaqU8VCgELkP7UZ5n552J1bsbr/F5GDIg7rP65lxJ1WusaOCQHZO
VwKvpM77mvmpubNgzBN3lshHxvU2mxh+AL7RWIWOKikhyrtGz7CWiLdsiJ3FIVYD
uQTQo+obghj7qLK3scnpYjg09xD77mE9C9IT7gPx+RXVh2eXdY+i+ugf9QN7Ikfz
QA8bViHY4ks5Rs+zX3xHVrAO7miq3fQAubVXVhm15UPZBHplJEblOgpqfV1HiW9M
vNKU+cVd860QeNjIhx23sdGm3cJqIvrGGmW7eg01nELjSfsnUbQwSoY2ewgX5rId
AlqWztX6mgUvnA4VVxEl9Q84SiHAAxB73nTudHwPcXrzLmwpvhHU8hsZGv5DFdjB
YVevbVZ5PsgNrWupTT8JBpUZc4nOmv4qHHwzZQGnFHXLkD2MWqQ=
=9zsd
-----END PGP SIGNATURE-----
--6xngppuugy4zdy47--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210225115005.ebfocnpwupvnjubk>