Date: Fri, 09 Sep 2016 11:56:15 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 211823] [patch] fsck_ffs incorrectly failing in check_cgmagic Message-ID: <bug-211823-8-Zs20ywsXgA@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211823-8@https.bugs.freebsd.org/bugzilla/> References: <bug-211823-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211823 --- Comment #2 from Christian Heckendorf <heckendorfc@gmail.com> --- This patch may very well be wrong since I have no knowledge of UFS internals but I assumed since these variables were being compared that the values were compatible (the value of sblock.fs_ipg able to fit in a data type the size = of cgp->cg_old_niblk). I don't see how comparing int16_t to uint32_t can be right :) Would you pre= fer to cast cgp->cg_old_niblk to uint32_t? As far as I could tell with a brief = look at their source, OpenBSD doesn't even compare these variables. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211823-8-Zs20ywsXgA>