Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Apr 2018 09:24:57 +0000 (UTC)
From:      =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <dumbbell@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r468615 - head/graphics/darktable
Message-ID:  <201804290924.w3T9OvDX050241@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dumbbell
Date: Sun Apr 29 09:24:57 2018
New Revision: 468615
URL: https://svnweb.freebsd.org/changeset/ports/468615

Log:
  graphics/darktable: Build with LLVM 6.0
  
  ... instead of LLVM 5.0. The reason is to stay in sync with Mesa to keep
  the number of LLVM copies to build to the minimum.
  
  It looks like the hack to explicitely set `LDFLAGS` to have OpenMP
  support isn't necessary anymore. The last time it was revisited was with
  LLVM 3.9.1.

Modified:
  head/graphics/darktable/Makefile

Modified: head/graphics/darktable/Makefile
==============================================================================
--- head/graphics/darktable/Makefile	Sun Apr 29 09:18:25 2018	(r468614)
+++ head/graphics/darktable/Makefile	Sun Apr 29 09:24:57 2018	(r468615)
@@ -3,7 +3,7 @@
 
 PORTNAME=	darktable
 PORTVERSION=	2.4.3
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics
 MASTER_SITES=	https://github.com/darktable-org/${PORTNAME}/releases/download/release-${PORTVERSION:C/\.rc/rc/}/
 
@@ -98,20 +98,13 @@ WEBP_CMAKE_OFF=		-DUSE_WEBP:BOOL=OFF
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} == amd64 && ${CHOSEN_COMPILER_TYPE} == clang
-# Enable OpenMP support with Clang 5.0.
-LLVM_VER=	50
+# Enable OpenMP support with Clang 6.0.
+LLVM_VER=	60
 BUILD_DEPENDS+=	clang${LLVM_VER}:devel/llvm${LLVM_VER}
 
 CPP=		clang-cpp${LLVM_VER}
 CC=		clang${LLVM_VER}
 CXX=		clang++${LLVM_VER}
-
-# FIXME: At least in 3.7.0 and 3.7.1, Clang doesn't find libomp.so
-# itself. Furthermore, there may be a regression in 3.7.1 because we now
-# need to explicitly link to libm.so as well. This remains true with
-# Clang 3.9.1.
-OPENMP_FLAGS=	-L${LOCALBASE}/llvm${LLVM_VER}/lib -lm -lomp
-LDFLAGS+=	${OPENMP_FLAGS}
 
 # Depend on devel/openmp instead of the full LLVM at runtime. Required
 # for a consistent libomp experience.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804290924.w3T9OvDX050241>