Date: Tue, 31 Jul 2018 15:46:35 +0300 From: Ruslan Makhmatkhanov <rm@FreeBSD.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org>, Ruslan Mahmatkhanov <rm@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: Re: svn commit: r475996 - branches/2018Q3/www/py-notebook Message-ID: <0d82ce84-ee61-bdd3-233c-7a24264b3927@FreeBSD.org> In-Reply-To: <CAMHz58RzPGN88eohyefNLtXxQvn9CMQZVCRTwdCWXo63HWxJBw@mail.gmail.com> References: <201807311239.w6VCd73n070432@repo.freebsd.org> <CAMHz58RzPGN88eohyefNLtXxQvn9CMQZVCRTwdCWXo63HWxJBw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Too bad. What I supposed to do now? Merge 5.6.0 there or revert this two mfced commits? Po-Chuan Hsieh wrote on 7/31/18 3:45 PM: > On Tue, Jul 31, 2018 at 8:39 PM Ruslan Makhmatkhanov <rm@freebsd.org> wrote: > >> Author: rm >> Date: Tue Jul 31 12:39:07 2018 >> New Revision: 475996 >> URL: https://svnweb.freebsd.org/changeset/ports/475996 >> >> Log: >> MFH: r475992 r475993 >> >> www/py-notebook: add missing dependencies >> >> Fix runtime by adding missing dependencies: prometheus-client is >> required for >> all versions and ipaddress is required for python 2.7. Bump PORTREVISION >> to >> chase a dependency change. >> >> With hat: python >> >> www/py-notebook: correct typo >> >> Approved by: portmgr (miwi) >> >> Modified: >> branches/2018Q3/www/py-notebook/Makefile >> Directory Properties: >> branches/2018Q3/ (props changed) >> >> Modified: branches/2018Q3/www/py-notebook/Makefile >> >> ============================================================================== >> --- branches/2018Q3/www/py-notebook/Makefile Tue Jul 31 12:32:45 2018 >> (r475995) >> +++ branches/2018Q3/www/py-notebook/Makefile Tue Jul 31 12:39:07 2018 >> (r475996) >> @@ -2,6 +2,7 @@ >> >> PORTNAME= notebook >> PORTVERSION= 5.5.0 >> > > Hello, > > The newly-added dependencies are for notebook 5.6.0, not 5.5.0. > > Regards, > sunpoet > > +PORTREVISION= 1 >> CATEGORIES= www python >> MASTER_SITES= CHEESESHOP >> PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} >> @@ -23,10 +24,17 @@ RUN_DEPENDS= >> ${PYTHON_PKGNAMEPREFIX}Jinja2>=0:devel/py >> >> ${PYTHON_PKGNAMEPREFIX}send2trash>=0:deskutils/py-send2trash@${PY_FLAVOR} >> \ >> ${PYTHON_PKGNAMEPREFIX}terminado>=0.8.1:net/py-terminado@${PY_FLAVOR} >> \ >> ${PYTHON_PKGNAMEPREFIX}tornado>=4:www/py-tornado@${PY_FLAVOR} >> \ >> - ${PYTHON_PKGNAMEPREFIX}traitlets>=4.2.1:devel/py-traitlets@ >> ${PY_FLAVOR} >> + ${PYTHON_PKGNAMEPREFIX}traitlets>=4.2.1:devel/py-traitlets@${PY_FLAVOR} >> \ >> + >> ${PYTHON_PKGNAMEPREFIX}prometheus-client>0:net-mgmt/py-prometheus-client@ >> ${PY_FLAVOR} >> >> NO_ARCH= yes >> USES= python >> USE_PYTHON= autoplist concurrent distutils >> >> -.include <bsd.port.mk> >> +.include <bsd.port.pre.mk> >> + >> +.if ${PYTHON_REL} < 3000 >> +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress@ >> ${PY_FLAVOR} >> +.endif >> + >> +.include <bsd.port.post.mk> -- Regards, Ruslan T.O.S. Of Reality
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0d82ce84-ee61-bdd3-233c-7a24264b3927>