Date: Thu, 9 Jul 2015 23:08:51 -0400 From: Patrick Kelsey <kelsey@ieee.org> To: Warner Losh <imp@bsdimp.com> Cc: George Neville-Neil <gnn@freebsd.org>, Peter Wemm <peter@wemm.org>, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285336 - in head/sys: netipsec opencrypto Message-ID: <CAD44qMV%2BXG6b4fg71=7g_1ZLFKbaZr%2BxQfgnN%2BR2YR4cRLLMBw@mail.gmail.com> In-Reply-To: <E599DA16-96AC-47BF-8157-25A0AFDF10C4@bsdimp.com> References: <201507091816.t69IGawf097288@repo.freebsd.org> <15342729.MI2b1tqqeb@overcee.wemm.org> <E82240DD-05F4-4CAD-B478-FF0948816FF0@freebsd.org> <E599DA16-96AC-47BF-8157-25A0AFDF10C4@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 9, 2015 at 10:45 PM, Warner Losh <imp@bsdimp.com> wrote: > > > On Jul 9, 2015, at 8:27 PM, George Neville-Neil <gnn@freebsd.org> wrote: > > > > > > > > On 9 Jul 2015, at 18:26, Peter Wemm wrote: > > > >> On Thursday, July 09, 2015 06:16:36 PM George V. Neville-Neil wrote: > >>> Author: gnn > >>> Date: Thu Jul 9 18:16:35 2015 > >>> New Revision: 285336 > >>> URL: https://svnweb.freebsd.org/changeset/base/285336 > >>> > >>> Log: > >>> Add support for AES modes to IPSec. These modes work both in software > >>> only mode and with hardware support on systems that have AESNI > >>> instructions. > >>> > >>> Differential Revision: D2936 > >>> Reviewed by: jmg, eri, cognet > >>> Sponsored by: Rubicon Communications (Netgate) > >>> > >>> Modified: > >>> head/sys/netipsec/xform_ah.c > >>> head/sys/netipsec/xform_esp.c > >> > >>> @@ -953,6 +989,11 @@ esp_output_cb(struct cryptop *crp) > >>> case CRYPTO_SHA2_512_HMAC: > >>> alen = esph->hashsize/2; > >>> break; > >>> + case CRYPTO_AES_128_GMAC: > >>> + case CRYPTO_AES_192_GMAC: > >>> + case CRYPTO_AES_256_GMAC: > >>> + alen = esph->hashsize; > >>> + break; > >>> default: > >>> alen = AH_HMAC_HASHLEN; > >>> break; > >> > >> This introduces a LINT compile failure: > >> > >> /usr/src/sys/netipsec/xform_esp.c:992:9: error: use of undeclared > identifier > >> 'CRYPTO_AES_128_GMAC' > >> case CRYPTO_AES_128_GMAC: > >> ^ > >> /usr/src/sys/netipsec/xform_esp.c:993:9: error: use of undeclared > identifier > >> 'CRYPTO_AES_192_GMAC' > >> case CRYPTO_AES_192_GMAC: > >> ^ > >> /usr/src/sys/netipsec/xform_esp.c:994:9: error: use of undeclared > identifier > >> 'CRYPTO_AES_256_GMAC' > >> case CRYPTO_AES_256_GMAC: > >> ^ > >> 3 errors generated. > >> --- xform_esp.o --- > >> > > > > Apologies, fixed in 285347. BTW The LINT conf in amd64 is ignored. Why? > > What do you mean? > > There was some temporary confusion regarding the LINT conf being dynamically generated (and thus properly ignored by svn), now resolved. -Patrick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD44qMV%2BXG6b4fg71=7g_1ZLFKbaZr%2BxQfgnN%2BR2YR4cRLLMBw>