Date: Tue, 4 Mar 2003 11:25:47 -0800 From: Sean Chittenden <sean@chittenden.org> To: Peter Pentchev <roam@ringlet.net> Cc: freebsd-doc@FreeBSD.org Subject: Re: Update to the handbook (NSFBUFS)... Message-ID: <20030304192547.GG79234@perrin.int.nxad.com> In-Reply-To: <20030304104211.GI518@straylight.oblivion.bg> References: <20030304000126.GV79234@perrin.int.nxad.com> <20030304104211.GI518@straylight.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
--4HoONH8zr3Mj5MZN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > Howdy. Much to my surprise, there's a lack of documentation on the > > 'sfbufa' state and what it means. Hopefully Google will pick this up > > and it'll make life easier for folks. There's a whitespace patch in > > there as well. > >=20 > > http://people.freebsd.org/~seanc/patches/#handbook_nsfbufs_update > >=20 > > These look alright? -sc >=20 > The whitespace patch looks great. Thx, committed. > For the NSFBUFS one, two comments. First, it may be better to use > 'may' instead of 'will' in the <important> section: if there are > enough sf_buf structures, the sendfile(2) call will not block at > all. Good catch, changed. > Second, since you are rewriting the whole paragraph above (the one > actually explaining what NSFBUFS is all about), it will be perfectly > acceptable to introduce a whitespace change (or fix) there: change > the leading spaces to tabs in all but the first line :) I didn't even check for that, emacs didn't change the spaces to tabs since the 1st indentation was done with spaces and not tabs. Fixed and committed. Thank you for reviewing the patch. -sc --=20 Sean Chittenden --4HoONH8zr3Mj5MZN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Comment: Sean Chittenden <sean@chittenden.org> iD8DBQE+ZP273ZnjH7yEs0ERAoIeAJ9sgIojyGWhaqGjvCC4lZ1xBRmdeQCcD6Dz tkQlpr9a9MBb+asaTQZLzwU= =gU6f -----END PGP SIGNATURE----- --4HoONH8zr3Mj5MZN-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030304192547.GG79234>