Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Aug 2019 09:17:21 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Tobias Kortkamp <tobik@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r508839 - head/graphics/svgbob/files
Message-ID:  <a7cc-dxmm-wny@FreeBSD.org>
In-Reply-To: <201908131743.x7DHh8fR094188@repo.freebsd.org> (Tobias Kortkamp's message of "Tue, 13 Aug 2019 17:43:08 %2B0000 (UTC)")
References:  <201908131743.x7DHh8fR094188@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Tobias Kortkamp <tobik@FreeBSD.org> writes:

> Author: tobik
> Date: Tue Aug 13 17:43:08 2019
> New Revision: 508839
> URL: https://svnweb.freebsd.org/changeset/ports/508839
>
> Log:
>   graphics/svgbob: Unbreak with Rust 1.37.0
[...]
>   Remove #![deny(warnings)] (basically the equivalent to -Werror in
>   C/C++) to fix the build with Rust 1.37.0 or greater.

If you can't convince upstream to drop #![deny(warnings)] in favor of
-Dwarnings specified by automation maybe pass --cap-lints warn to avoid
patch churn on updates. Probably doesn't matter much in this port.

Index: graphics/svgbob/Makefile
===================================================================
--- graphics/svgbob/Makefile	(revision 508894)
+++ graphics/svgbob/Makefile	(working copy)
@@ -14,6 +14,7 @@ USES=		cargo
 USE_GITHUB=	yes
 GH_ACCOUNT=	ivanceras
 GH_TAGNAME=	c3e84c87094550d8cdc6fc48b40a00712b2951cb
+RUSTFLAGS+=	--cap-lints warn # ignore #![deny(warnings)]
 
 CARGO_CRATES=	ansi_term-0.11.0 \
 		atty-0.2.11 \
Index: graphics/svgbob/files/patch-src_main.rs
===================================================================
--- graphics/svgbob/files/patch-src_main.rs	(revision 508894)
+++ graphics/svgbob/files/patch-src_main.rs	(nonexistent)
@@ -1,41 +0,0 @@
-error: the item `exit` is imported redundantly
-  --> src/main.rs:86:25
-   |
-16 | use std::process::exit;
-   |     ------------------ the item `exit` is already imported here
-...
-86 |                     use std::process::exit;
-   |                         ^^^^^^^^^^^^^^^^^^
-   |
-
---- src/main.rs.orig	2019-04-12 08:16:01 UTC
-+++ src/main.rs
-@@ -1,4 +1,3 @@
--#![deny(warnings)]
- #[macro_use]
- extern crate clap;
- 
-@@ -83,7 +82,6 @@ fn main() {
-                 }
-                 Err(e) => {
-                     use std::io::Write;
--                    use std::process::exit;
- 
-                     writeln!(
-                         &mut std::io::stderr(),
-@@ -124,7 +122,6 @@ fn main() {
-     if let Some(file) = args.value_of("output") {
-         if let Err(e) = svg::save(file, &svg) {
-             use std::io::Write;
--            use std::process::exit;
- 
-             writeln!(
-                 &mut std::io::stderr(),
-@@ -148,7 +145,6 @@ where
-             Ok(a) => Some(a),
-             Err(e) => {
-                 use std::io::Write;
--                use std::process::exit;
- 
-                 writeln!(
-                     &mut std::io::stderr(),

Property changes on: graphics/svgbob/files/patch-src_main.rs
___________________________________________________________________
Deleted: fbsd:nokeywords
## -1 +0,0 ##
-yes
\ No newline at end of property
Deleted: svn:eol-style
## -1 +0,0 ##
-native
\ No newline at end of property
Deleted: svn:mime-type
## -1 +0,0 ##
-text/plain
\ No newline at end of property



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a7cc-dxmm-wny>