Date: Mon, 20 Apr 2009 00:40:03 +0400 From: Chagin Dmitry <dchagin@FreeBSD.org> To: Roman Divacky <rdivacky@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191269 - head/sys/compat/linux Message-ID: <20090419204002.GA6716@dchagin.static.corbina.ru> In-Reply-To: <20090419202253.GA28306@freebsd.org> References: <200904191348.n3JDmhVH010871@svn.freebsd.org> <20090419202253.GA28306@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 19, 2009 at 10:22:53PM +0200, Roman Divacky wrote: > On Sun, Apr 19, 2009 at 01:48:43PM +0000, Dmitry Chagin wrote: > > Author: dchagin > > Date: Sun Apr 19 13:48:42 2009 > > New Revision: 191269 > > URL: http://svn.freebsd.org/changeset/base/191269 > >=20 > > Log: > > Remove support for FUTEX_REQUEUE operation. > > Glibc does not use this operation since 2.3.3 version (Jun 2004), > > as it is racy and replaced by FUTEX_CMP_REQUEUE operation. > > Glibc versions prior to 2.3.3 fall back to FUTEX_WAKE when > > FUTEX_REQUEUE returned EINVAL. > > =20 > > Any application directly using FUTEX_REQUEUE without return > > value checking are definitely broken. > > =20 > > Limit quantity of messages per process about unsupported > > operation. > > =20 > > Approved by: kib (mentor) > > MFC after: 1 month > >=20 > > Modified: > > head/sys/compat/linux/linux_emul.c > > head/sys/compat/linux/linux_emul.h > > head/sys/compat/linux/linux_futex.c > >=20 > > Modified: head/sys/compat/linux/linux_emul.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/compat/linux/linux_emul.c Sun Apr 19 12:41:37 2009 (r19126= 8) > > +++ head/sys/compat/linux/linux_emul.c Sun Apr 19 13:48:42 2009 (r19126= 9) > > @@ -86,6 +86,7 @@ linux_proc_init(struct thread *td, pid_t > > em =3D malloc(sizeof *em, M_LINUX, M_WAITOK | M_ZERO); > > em->pid =3D child; > > em->pdeath_signal =3D 0; > > + em->used_requeue =3D 0; > > em->robust_futexes =3D NULL; > > if (flags & LINUX_CLONE_THREAD) { > > /* handled later in the code */ > >=20 > > Modified: head/sys/compat/linux/linux_emul.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/compat/linux/linux_emul.h Sun Apr 19 12:41:37 2009 (r19126= 8) > > +++ head/sys/compat/linux/linux_emul.h Sun Apr 19 13:48:42 2009 (r19126= 9) > > @@ -51,6 +51,7 @@ struct linux_emuldata { > > struct linux_emuldata_shared *shared; > > =20 > > int pdeath_signal; /* parent death signal */ > > + int used_requeue; /* uses deprecated futex op */ >=20 > what is the point of this variable? it's only set and never read hi, hmm, it is the counter. it is used, you cut off this piece of a code in the reply. --=20 Have fun! chd --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) iEYEARECAAYFAknrjCEACgkQ0t2Tb3OO/O2IIQCfRWaDZsKuJ6fiQHWucTliPTHQ jvoAoJp23sOXWtgIssVgPwErUEYbgKmI =ASMW -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090419204002.GA6716>