Date: Sat, 11 Jan 2003 20:08:35 -0800 From: Alfred Perlstein <bright@mu.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Jake Burkholder <jake@locore.ca>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... Message-ID: <20030112040835.GA33821@elvis.mu.org> In-Reply-To: <200301120254.h0C2srcS043241@apollo.backplane.com> References: <200301120137.h0C1bD0E098037@repoman.freebsd.org> <20030111213259.E212@locore.ca> <200301120254.h0C2srcS043241@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Matthew Dillon <dillon@apollo.backplane.com> [030111 18:55] wrote: > > It's a cleanup. Ugliness I noticed as I was evaluating how easy it > would be to add a memory object file type. I don't see why you believe > a justification is required other then cleanup and code readability. > void *'s are things you only use when you need to. We certainly didn't > need to here. How exactly is this commit so bad that you are against it? What about third party/loadable DTYPEs? Isn't this more annoying than helpful for that case? You've also broken the style of this file by removing the f_ prefix. Please fix. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030112040835.GA33821>