Date: Fri, 23 Jan 2015 14:49:05 -0700 From: Alan Somers <asomers@freebsd.org> To: Davide Italiano <davide@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Will Andrews <will@freebsd.org> Subject: Re: svn commit: r277570 - head/usr.bin/vmstat Message-ID: <CAOtMX2jg1AwGkD%2BGShSRRdNyCj9X-jLt1LyS2Hq4TdwN5%2BA43w@mail.gmail.com> In-Reply-To: <CACYV=-HSU99V8MD%2B38Cgj9FP-ehhJ=RcxfPyqoFJSG5ySpEA5A@mail.gmail.com> References: <201501231618.t0NGIeDv057991@svn.freebsd.org> <CACYV=-HthyZ061GSs_2=mNXa676we9MqSNVPcWRXur_Z6zD1xA@mail.gmail.com> <20150123205617.GB56104@sol.firepipe.net> <CACYV=-HSU99V8MD%2B38Cgj9FP-ehhJ=RcxfPyqoFJSG5ySpEA5A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 23, 2015 at 2:18 PM, Davide Italiano <davide@freebsd.org> wrote: > On Fri, Jan 23, 2015 at 12:56 PM, Will Andrews <will@freebsd.org> wrote: >> On Fri, Jan 23, 2015 at 11:23:57AM -0800, Davide Italiano wrote: >>> What's the rationale behind this change? >> >> The rationale was to match the clock used to the name (and implied intent) >> of the variables used to store/manipulate the data. >> >> It's possible that 'uptime' is entirely the wrong term in vmstat, in which >> case the naming used elsewhere in vmstat needs to be changed too. >> >> -- >> wca > > I don't think this is a reason strong enough, we should rather go the > other way around as already suggested. > I would like to see this reverted. > > Thanks, > > -- > Davide > I agree with Ian that vmstat ought to be using a monotonic clock, and that the ideal change would be to rename all of its "uptime" variables accordingly. But reverting this change would be the worst possible outcome because we'd be back in the original situation of wrong variable names that are wrongly set. As is, the change has no functional effect because CLOCK_MONOTONIC and CLOCK_UPTIME are identical (see kern_clock_gettime). -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2jg1AwGkD%2BGShSRRdNyCj9X-jLt1LyS2Hq4TdwN5%2BA43w>