Date: 12 Jun 2009 10:51:16 -0000 From: Lapo Luchini <lapo@lapo.it> To: FreeBSD-gnats-submit@FreeBSD.org Cc: Lapo Luchini <lapo@lapo.it>, obrien@FreeBSD.org Subject: ports/135500: net/rdesktop sound does not work [PATCH] Message-ID: <20090612105116.35457.qmail@mail.lapo.it> Resent-Message-ID: <200906121100.n5CB06VZ019533@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 135500 >Category: ports >Synopsis: net/rdesktop sound does not work [PATCH] >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Jun 12 11:00:06 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Lapo Luchini >Release: FreeBSD 6.4-STABLE amd64 >Organization: >Environment: System: FreeBSD motoko.lapo.it 6.4-STABLE FreeBSD 6.4-STABLE #9: Thu Jan 29 15:50:58 CET 2009 root@motoko.lapo.it:/usr/obj/usr/src/sys/MOTOKO amd64 >Description: Remote sounds over RDP doesn't seem to work. >How-To-Repeat: When connecting to a Windows7 virtual machine, I try to receive sound with the following line: rdesktop -r sound:local:libao and indeed the Windows speaker tray-icon says "remote audio". But when I try to play a sound (e.g. in control panes, sounds) the play button doesn't stay disabled for the sound duration (probably the play-sound syscall fails). >Fix: I found this patch at this address, with the name "Rdp Sound in Vista [PATCH]" (which might well be related to my case as well, since Win7 is after Vista; or maybe it also happens with remote WinXPs, I didn't check that). Using this patch the sound can be heard, and the play button is disabled for the sound duration. http://sourceforge.net/mailarchive/forum.php?thread_name=200902131243.10881.sameer.subscriptions%40damagehead.com&forum_name=rdesktop-devel --- patch-rdpdr.c begins here --- --- rdpdr.c.orig 2008-02-14 12:37:17.000000000 +0100 +++ rdpdr.c 2009-06-12 12:41:18.000000000 +0200 @@ -841,14 +841,11 @@ rdpdr_process(STREAM s) RD_BOOL rdpdr_init() { - if (g_num_devices > 0) - { - rdpdr_channel = - channel_register("rdpdr", - CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_COMPRESS_RDP, - rdpdr_process); - } - + rdpdr_channel = + channel_register("rdpdr", + CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_COMPRESS_RDP, + rdpdr_process); + return (rdpdr_channel != NULL); } --- patch-rdpdr.c ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090612105116.35457.qmail>