Date: Mon, 7 Jul 2014 19:46:14 +0100 From: Barrie Archer <enquiry@myarcher.net> To: Ryan Steinmetz <zi@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>, Mathieu Arnold <mat@FreeBSD.org> Cc: perl@freebsd.org, portmgr@freebsd.org Subject: Re: p5-Git-Repository Message-ID: <53BAE9C0.9050801@myarcher.net> In-Reply-To: <20140707162734.GC74596@exodus.zi0r.com> References: <53BA9AD8.7030906@myarcher.net> <20140707134409.GA12289@exodus.zi0r.com> <D6280EB537813A51DA64B820@ogg.in.absolight.net> <20140707161318.GB74596@exodus.zi0r.com> <20140707161913.GB97203@ivaldir.etoilebsd.net> <20140707162734.GC74596@exodus.zi0r.com>
next in thread | previous in thread | raw e-mail | index | archive | help
From an simple user's point of view this is exactly what is required, (a) a warning that things may go wrong, and (b) a probable cause if they do. Regards Barrie On 07/07/2014 17:27, Ryan Steinmetz wrote: On (07/07/14 18:19), Baptiste Daroussin wrote: On Mon, Jul 07, 2014 at 12:13:18PM -0400, Ryan Steinmetz wrote: On (07/07/14 17:55), Mathieu Arnold wrote: >+--On 7 juillet 2014 09:44:09 -0400 Ryan Steinmetz [1]<zi@FreeBSD.org> wrote: >| We should either add workarounds for older systems or a warning >| that will be printed if a user is running a FreeBSD release that lacks >| required functionality for the ports tree to function. > >Well, the ports tree is only guaranteed to work with supported FreeBSD >releases. So, if you're not running a supported release, you're on your own. > >We can't add bits and pieces of version checks around everything that won't >work with older releases. We know what the supported releases are and we can easily add a check to the framework to verify that you are running a supported release and print a message if not. This would be identical to what was done with the PKGNG checks/warnings. The goal is to give the user a useful message ("You are using an unsupported version, please upgrade.") versus the errors that Barrie ran into ("Unknown modifier 't'" or "make: fatal errors encountered -- cannot continue"). Except that is that case it is impossible to catch it reliably, some impossible to warn about it. We don't need to catch anything. We simply need: .if (${OSVERSION} >= 902510 && ${OSVERSION} < 1000000) || ${OSVERSION} >= 1000704 ${ECHO} "You are using an unsupported release. The ports tree may not function correctly. Please update to a supported release for the best experience. See [2]http://.....freebsd.org/... for a list of supported releases. .endif Obviously the versions are not correct, but, again, the goal is to give people something to work with. Just like what we did with the PKGNG warnings. -r regards, Bapt --Certified Virus Free by 4SecureMail.com ICSA-Certified Scanner-- References 1. mailto:zi@FreeBSD.org 2. http://.....freebsd.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53BAE9C0.9050801>