Date: Fri, 9 Sep 2011 04:42:12 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r225457 - user/adrian/if_ath_tx/sys/dev/ath Message-ID: <201109090442.p894gC4Z021798@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Fri Sep 9 04:42:11 2011 New Revision: 225457 URL: http://svn.freebsd.org/changeset/base/225457 Log: .. add this little gem of a reminder. Yes, why is sc_lastrx being updated in the TX handler? Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Fri Sep 9 04:41:14 2011 (r225456) +++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Fri Sep 9 04:42:11 2011 (r225457) @@ -4455,6 +4455,7 @@ ath_tx_proc_q0(void *arg, int npending) struct ifnet *ifp = sc->sc_ifp; if (txqactive(sc->sc_ah, 0) && ath_tx_processq(sc, &sc->sc_txq[0])) + /* XXX why is lastrx updated in tx code? */ sc->sc_lastrx = ath_hal_gettsf64(sc->sc_ah); if (txqactive(sc->sc_ah, sc->sc_cabq->axq_qnum)) ath_tx_processq(sc, sc->sc_cabq);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109090442.p894gC4Z021798>