Date: Thu, 08 Feb 2018 10:10:17 +0100 From: Ganael Laplanche <ganael.laplanche@centralesupelec.fr> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Mark Linimon <linimon@lonesome.com>, Alexey Dokuchaev <danfe@freebsd.org>, Ganael LAPLANCHE <martymac@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r460940 - in head/games: afternoonstalker burgerspace cosmosmash Message-ID: <2650675.ed8esFDKD5@dmc12.centralesupelec.fr> In-Reply-To: <20180208083213.yzrjhl4lwuqykvpg@ivaldir.net> References: <201802041634.w14GYHVW017651@repo.freebsd.org> <20180208071931.GA13039@lonesome.com> <20180208083213.yzrjhl4lwuqykvpg@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 08 February 2018 09:32:13 Baptiste Daroussin wrote: Hi everyone, > > > ... by forcing gnu++98 without giving the details of the breakages and > > > why they were not properly fixed instead. :-) > > > > For once I'm going to agree with danfe (someone take a picture!) but only > > to the extent that I would like to ask that the commit messages be "work > > around the build" rather than "fix". There have been numerous commits > > that did contain actual code fixes. I should probably have written a more detailed commit msg, sorry. > My point here, is variations between c++ standards may make some code > incompatible and sometime the version of the standard may/should be > specified, because the code is clearly C++98. > > In clang 6 when you build c++ instead of defaulting of c++98 like it used to > be is now defaulting on c++14 meaning all the code whihch expected c++98 as > default standard are now broken and the -std flag should be supplied. The > same happened when the C compilers switched from C89 to C99 as default > standard. On 143 ports we needed to make that change. > > Being compatible with newer c++ standard is an upstream decision to take, > not hours. The compilers are able to specify the standard you are using, > imho it is normal and expected for maintainers to use that feature :) I agree with Bapt, if a project is written in C++ 98, that is not the porter's job to re-write it into a newer standard, that's why specifying c++98 for those ports made sense to me. Moreover, those games have not seen updates for years now, so there may be not point in updating their code standard. Best regards, -- Ganael Laplanche <ganael.laplanche@centralesupelec.fr> Unix Systems Engineer @CentraleSupelec Rennes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2650675.ed8esFDKD5>