Date: Mon, 28 Jun 2010 14:44:49 -0400 From: John Baldwin <jhb@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: threads@freebsd.org Subject: Re: SIGPIPE and threads Message-ID: <201006281444.50021.jhb@freebsd.org> In-Reply-To: <20100628140534.GZ13238@deviant.kiev.zoral.com.ua> References: <201006280833.54224.jhb@freebsd.org> <20100628140534.GZ13238@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 28 June 2010 10:05:34 am Kostik Belousov wrote: > On Mon, Jun 28, 2010 at 08:33:54AM -0400, John Baldwin wrote: > > Currently when a thread performs a write(2) on a disconnected socket or a FIFO > > with no readers the SIGPIPE signal is posted to the entire process via > > psignal(). This means that the signal can be delivered to any thread in the > > process. However, it seems more intuitive to me that SIGPIPE should be sent > > to the "offending" thread similar to signals sent in response to traps via > > trapsignal(). POSIX seems to require this in that the description of the > > EPIPE error return value for write(2) and fflush(3) in the Open Group's online > > manpages both say that SIGPIPE should be sent to the current thread in > > addition to returning EPIPE: > > > > http://www.opengroup.org/onlinepubs/000095399/functions/write.html > > > > http://www.opengroup.org/onlinepubs/000095399/functions/fflush.html > > > > I have an untested (only compiled) patch below: > > I think the patch is right, but, as you note, having a dedicated > function that wraps automatic ksi initialization and tdsignal() > call would be even better. Ok, what I've done is to rename tdsignal() to tdsendsignals() and make it private to kern_sig.c. I then added 'tdsignal()' and 'tdksignal()' to the public KPI to mirror the existing psignal() and pksignal() routines. This patch can be found at http://www.freebsd.org/~jhb/patches/tdsignal.patch I then reworked the sigpipe patch to just convert calls to psignal() to tdsignal() instead. It is at http://www.freebsd.org/~jhb/patches/sigpipe.patch -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006281444.50021.jhb>