Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 1999 16:46:21 -0400 (EDT)
From:      "Brian F. Feldman" <green@FreeBSD.org>
To:        Nate Williams <nate@mt.sri.com>
Cc:        Alfred Perlstein <bright@rush.net>, hackers@FreeBSD.org, freebsd-ipfw@FreeBSD.org, bde@FreeBSD.org
Subject:   Re: securelevel and ipfw zero
Message-ID:  <Pine.BSF.4.10.9907281643400.92555-100000@janus.syracuse.net>
In-Reply-To: <199907282040.OAA03306@mt.sri.com>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
On Wed, 28 Jul 1999, Nate Williams wrote:

> > > > *rant on*
> > > > Brian, FreeBSD isn't your private playground for playing around, this is
> > > > a group project, and you gotta follow the rules, or you don't get to
> > > > play with the rest of the folks....
> > > 
> > > The rules don't say "leave the code that you work with in a bigger mess than
> > > when you started." Cleaning up code is a fact of life, and it _NEEDS_ to be
> > > done to get work done, very often. You have to learn to deal with that.
> > > 
> > > > *rant off*
> > 
> > and so it should remain, changes that provide readability to
> > code should be committed, the only time documentation of code
> > is wrong is when it it is incorrect.
> 
> The changes pointed out do *NOT* make the code more readable.  They just
> move statements around for no reason, and change whitespace.

It makes it more readable if you understand and use KNF instead of
try to bastardize everyone else's code.

> 
> > Increasing the size of the cvs repo is not a consideration when
> > worthwhile docs can be incorperated, especially when the person
> > who needs to maintain it requires changess for readability.
> 
> Brian is *NOT* the maintainer, he is the author of a patch to it.

I'm one of the people who actively works on it. Who are you?

> 
> Doesn't anyone care for keeping the source code consistant *AND*
> maintainable for multiple people, as well as maintaining a history of
> *CHANGES* for people to review in the future?

What do you think KNF is about? I'll bring out the big guns now (BDE).

> 
> Or is this Linux, where we don't give a rip and whatever the current
> patch does to the rest of the tree is fine, since the more code we have
> the better?
> 

You have no idea what you're talking about, WRT FreeBSD.

> 
> 
> Nate
> 

 Brian Fundakowski Feldman      _ __ ___ ____  ___ ___ ___  
 green@FreeBSD.org                   _ __ ___ | _ ) __|   \ 
     FreeBSD: The Power to Serve!        _ __ | _ \._ \ |) |
       http://www.FreeBSD.org/              _ |___/___/___/ 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ipfw" in the body of the message




Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9907281643400.92555-100000>