Date: Thu, 2 Apr 2020 16:48:46 +0000 (UTC) From: Ed Maste <emaste@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r359568 - stable/12/sys/dev/usb/net Message-ID: <202004021648.032GmkOR019804@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: emaste Date: Thu Apr 2 16:48:46 2020 New Revision: 359568 URL: https://svnweb.freebsd.org/changeset/base/359568 Log: MFC r359006: muge: enable RXCSUM as it now works Modified: stable/12/sys/dev/usb/net/if_muge.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/usb/net/if_muge.c ============================================================================== --- stable/12/sys/dev/usb/net/if_muge.c Thu Apr 2 15:37:40 2020 (r359567) +++ stable/12/sys/dev/usb/net/if_muge.c Thu Apr 2 16:48:46 2020 (r359568) @@ -54,9 +54,7 @@ __FBSDID("$FreeBSD$"); * A number of features supported by the lan78xx are not yet implemented in * this driver: * - * - RX/TX checksum offloading: Nothing has been implemented yet for - * TX checksumming. RX checksumming works with ICMP messages, but is broken - * for TCP/UDP packets. + * - TX checksum offloading: Nothing has been implemented yet. * - Direct address translation filtering: Implemented but untested. * - VLAN tag removal. * - Support for USB interrupt endpoints. @@ -122,7 +120,6 @@ SYSCTL_INT(_hw_usb_muge, OID_AUTO, debug, CTLFLAG_RWTU "Debug level"); #endif -#define MUGE_DEFAULT_RX_CSUM_ENABLE (false) #define MUGE_DEFAULT_TX_CSUM_ENABLE (false) #define MUGE_DEFAULT_TSO_ENABLE (false) @@ -1610,8 +1607,7 @@ muge_attach_post_sub(struct usb_ether *ue) */ ifp->if_capabilities |= IFCAP_VLAN_MTU; ifp->if_hwassist = 0; - if (MUGE_DEFAULT_RX_CSUM_ENABLE) - ifp->if_capabilities |= IFCAP_RXCSUM; + ifp->if_capabilities |= IFCAP_RXCSUM; if (MUGE_DEFAULT_TX_CSUM_ENABLE) ifp->if_capabilities |= IFCAP_TXCSUM;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004021648.032GmkOR019804>