Date: Wed, 31 Oct 2012 20:51:42 +0000 (UTC) From: Chris Rees <crees@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r242405 - user/crees/rclint Message-ID: <201210312051.q9VKpgcl028332@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: crees (ports committer) Date: Wed Oct 31 20:51:41 2012 New Revision: 242405 URL: http://svn.freebsd.org/changeset/base/242405 Log: Be more relaxed about quoting by being observant of POSIX, rather than our sh's behaviour Submitted by: jilles Modified: user/crees/rclint/rclint.py Modified: user/crees/rclint/rclint.py ============================================================================== --- user/crees/rclint/rclint.py Wed Oct 31 19:17:55 2012 (r242404) +++ user/crees/rclint/rclint.py Wed Oct 31 20:51:41 2012 (r242405) @@ -109,11 +109,10 @@ class Statement: def pointless_quoted(self): if self.quoted(): - if self.type == 'shorthand': - return True - elif ' ' not in self.value and '\t' not in self.value: - return True - return False + for char in self.value: + if char in ' \t|&;<>()$`\\\"\'': + return False + return True class Variable(Statement): def __init__(self, lines, number):
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210312051.q9VKpgcl028332>