Date: Sun, 17 Mar 2013 12:19:31 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: freebsd-arch@FreeBSD.org Subject: Re: chflagsat(2). Message-ID: <20130317111931.GD1364@garage.freebsd.pl> In-Reply-To: <20130317064338.GN3794@kib.kiev.ua> References: <20130317004908.GB1364@garage.freebsd.pl> <20130317064338.GN3794@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--fOHHtNG4YXGJ0yqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 17, 2013 at 08:43:38AM +0200, Konstantin Belousov wrote: > On Sun, Mar 17, 2013 at 01:49:08AM +0100, Pawel Jakub Dawidek wrote: > > Hi. > >=20 > > The following patch adds chflagsat(2) syscall to complete other *at > > syscalls: > >=20 > > http://people.freebsd.org/~pjd/patches/chflagsat.patch > >=20 > > Note that the name chflagsat was carefully choosen instead of > > fchflagsat, to not repeat POSIX (more likely Linux) mistakes of using > > fchmodat, fchownat, futimesat, etc. names when they really shouldn't > > start with an 'f'. >=20 > This is the only point I do not agree with the patch. I prefer to have > the syscall name consistent with the other syscalls. There are quite a few *at() syscalls and only few of them have bogus 'f' prefix (fchmodat, fchownat, fstatat, futimesat). Most of them don't (bindat, connectat, linkat, mkdirat, mkfifoat, mknodat, openat, renameat, symlinkat, unlinkat). 'f' is of course bogus, because the syscalls don't operate on descriptors, but on paths. Also note that POSIX is moving aways from those mistakes and eventhough they standarized futimesat(), they now use utimensat() for nanosecond precision timestamps to stop those mistakes. This is actually the argument jilles' convinced me to use chflagsat instead of fchflagsat, which is originally used. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --fOHHtNG4YXGJ0yqR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFFpsMACgkQForvXbEpPzTNuQCg05X9vRhXLwqb4PaSiWyuHmpz EKsAnRKukxsilLbJQUIVN9nZ2BrguQ1B =/X6D -----END PGP SIGNATURE----- --fOHHtNG4YXGJ0yqR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130317111931.GD1364>