Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Feb 2010 15:41:46 -0500
From:      Graham Todd <gtodd@bellanet.org>
To:        Gabor Kovesdan <gabor@FreeBSD.org>
Cc:        freebsd-current@freebsd.org
Subject:   Re: HEADSUP: BSDL bc/dc in head and -ledit
Message-ID:  <4B731A0A.9030105@bellanet.org>
In-Reply-To: <4B6D6663.4070905@FreeBSD.org>
References:  <4B57780F.4070907@FreeBSD.org>	<4B6970F8.2030807@FreeBSD.org>	<90a5caac1002040231i13c2b47mc733947a767d3488@mail.gmail.com>	<4B6ACA37.3060807@FreeBSD.org>	<4B6AF30B.4040204@bellanet.org> <4B6D6663.4070905@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Gabor Kovesdan wrote:
> El 2010. 02. 04. 17:17, Graham Todd escribió:
>> Hi, sorry to be OT.  If libedit can be swapped for libreadline in the
>> BSDL bc is it possible to swap them elsewhere? 

[snip]

> Probably, the problem is just nobody has taken care of these yet. I'd be
> interested later if noone solves these before.

There was some discussion (9-10 years ago) about replacing libreadline
with libedit, either as a drop in replacement w/ compatibility layer or in
a simpler form for the base system (i.e. other than gdb/kgdb).  The good
news is that the upstream versions of ntp and heimdal now build using
-ledit so everything has happened on its own in the fullness of time :)  I
guess as they are imported -ledit will gradually become the default for
these tools??

I couldn't find any libedit knobs for building ntpq/ntpdc in src, but
building the latest ntp release candidate (4.2.6p1-RC5) or development
version (4.2.7p19) from source uses libedit with libreadline as a option.

 ChangeLog:* [Bug 931] Require -lreadline to be asked for explicitly.

$ ~/local/src/ntp-dev-4.2.7p19 % ldd ntpq/ntpq | grep libedit
	libedit.so.6 => /lib/libedit.so.6 (0x280ad000)

$ ~/local/src/ntp-dev-4.2.7p19 % ldd ntpdc/ntpdc | grep libedit
	libedit.so.6 => /lib/libedit.so.6 (0x280af000)

Both ktutil and kadmin from heimdal-1.1 and heimdal-1.3.1 work as well.
	
$ ~/local/src/heimdal-1.1 % ldd admin/.libs/ktutil | grep libedit
	libedit.so.6 => /lib/libedit.so.6 (0x28308000)
	
$ ~/local/src/heimdal-1.1 % ldd kadmin/.libs/kadmin | grep libedit
	libedit.so.6 => /lib/libedit.so.6 (0x280c3000)

$ ~/local/src/heimdal-1.3.1 % ldd admin/.libs/ktutil | grep libedit
	libedit.so.6 => /lib/libedit.so.6 (0x28279000)

$ ~/local/src/heimdal-1.3.1 % ldd  kadmin/.libs/kadmin | grep libedit
	libedit.so.6 => /lib/libedit.so.6 (0x280c4000)
	
I think gvinum had a "libedit" patch at one point but it's likely stale.
The patch Xin Li sent for bc/dc makes replacing readline with editline
support look easier than it is!! ;-)

Anyway a big thanks to you and other developers for your work improving
FreeBSD.

Cheers



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B731A0A.9030105>