Date: Wed, 9 Sep 2015 22:06:07 -0400 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Jan Beich <jbeich@freebsd.org> Cc: Jason Unovitch <junovitch@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Chris Hutchinson <portmaster@bsdforge.com>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r396547 - in head/textproc: . smi Message-ID: <CACM2dAaD=7uqRN89E2d1=t7yCR3GzDCy8TiB-CX1J6g2D8QD1w@mail.gmail.com> In-Reply-To: <k2rz-5a24-wny@FreeBSD.org> References: <201509100045.t8A0jQFW087140@repo.freebsd.org> <k2rz-5a24-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Well gosh. I must not approve things while crszy.
Thanks Jan!
On Wednesday, September 9, 2015, Jan Beich <jbeich@freebsd.org> wrote:
> Jason Unovitch <junovitch@FreeBSD.org> writes:
>
> > +post-patch:
> > + ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \
>
> CC is defined by default to a sane value in both GNU and BSD make.
> One can do '/^CC/d' but see below for better way.
>
> > + -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \
> ^^^
> Typo: l .vs I. It still works because PREFIX is also passed via MAKE_ENV.
>
> > + -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \
> > + ${WRKSRC}/config.mk
>
> If possible try to avoid patching makefiles if overriding a few
> variables is enough. For one, your entire post-patch can be:
>
> MAKE_ARGS= CC="${CC}" PREFIX="${PREFIX}" MANPREFIX="${MANPREFIX}"
>
--
---------------------------------------------------------------------------------
Curb: Your ride is here
4096R/D21D2752
<http://pgp.mit.edu/pks/lookup?op=get&search=0xF699A450D21D2752>; ECDF B597
B54B 7F92 753E E0EA F699 A450 D21D 2752
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Member, Apache Software Foundation
Committer, FreeBSD Foundation
Consultant, P6M7G8 Inc.
Sr. Director IT Operations, Curb
What doesn't kill us can only make us stronger;
Except it almost kills you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACM2dAaD=7uqRN89E2d1=t7yCR3GzDCy8TiB-CX1J6g2D8QD1w>