Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Jul 2017 13:03:22 +0200 (CEST)
From:      =?ISO-8859-1?Q?Trond_Endrest=F8l?= <Trond.Endrestol@fagskolen.gjovik.no>
To:        FreeBSD stable <freebsd-stable@freebsd.org>
Subject:   Re: r321601 causes make buildworld to fail on stable/11
Message-ID:  <alpine.BSF.2.21.1707271301520.53090@mail.fig.ol.no>
In-Reply-To: <4d589d27-8546-51f5-d7d6-50736eb7534b@zyxst.net>
References:  <alpine.BSF.2.21.1707271129500.53090@mail.fig.ol.no> <4d589d27-8546-51f5-d7d6-50736eb7534b@zyxst.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 Jul 2017 11:57+0100, tech-lists wrote:

> On 27/07/2017 10:33, Trond Endrestøl wrote:
> > r321601 gives me these error messages on stable/11:
> > 
> > /usr/src/usr.sbin/acpi/acpidump/acpi.c:1089:6: error: use of undeclared identifier 'ACPI_SRAT_TYPE_GIC_ITS_AFFINITY'; did you mean 'ACPI_SRAT_TYPE_GICC_AFFINITY'?
> >     [ACPI_SRAT_TYPE_GIC_ITS_AFFINITY] = "GIC ITS",
> >      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >      ACPI_SRAT_TYPE_GICC_AFFINITY
> > /usr/src/sys/contrib/dev/acpica/include/actbl1.h:1504:5: note: 'ACPI_SRAT_TYPE_GICC_AFFINITY' declared here
> >     ACPI_SRAT_TYPE_GICC_AFFINITY        = 3,
> >     ^
> > /usr/src/usr.sbin/acpi/acpidump/acpi.c:1089:41: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> >     [ACPI_SRAT_TYPE_GIC_ITS_AFFINITY] = "GIC ITS",
> >                                         ^~~~~~~~~
> > /usr/src/usr.sbin/acpi/acpidump/acpi.c:1088:38: note: previous initialization is here
> >     [ACPI_SRAT_TYPE_GICC_AFFINITY] = "GICC",
> >                                      ^~~~~~
> > 
> > Am I missing something? Am acpi.c missing something?
> > 
> 
> I see this as well on r321611

r321600 builds fine.
r321601 does not, and must be amended or reverted.

-- 
Trond.
From owner-freebsd-stable@freebsd.org  Thu Jul 27 11:19:03 2017
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 81338DC852F
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Thu, 27 Jul 2017 11:19:03 +0000 (UTC)
 (envelope-from herbert@mailbox.org)
Received: from mx1.mailbox.org (mx1.mailbox.org [80.241.60.212])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "*.mailbox.org",
 Issuer "SwissSign Server Silver CA 2014 - G22" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 411D071FB7;
 Thu, 27 Jul 2017 11:19:02 +0000 (UTC)
 (envelope-from herbert@mailbox.org)
Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.mailbox.org (Postfix) with ESMTPS id B501E4617C;
 Thu, 27 Jul 2017 13:18:53 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h=
 content-type:content-type:mime-version:references:message-id
 :in-reply-to:subject:subject:from:from:date:date:received; s=
 mail20150812; t=1501154331; bh=2P/5D5PaooAEyoYYWbL9UUzeOo7OvYWkh
 JbetyMz8Rs=; b=h5+87h+nHXwAVaIM2B/h/nd8pfdfhoLR2EOL409GD5+nayZtw
 6+Q9YCnZmOEMilhBz5JOXp+CcghY+SA4nQdrUYpJ/WCWtX8usCk2Gd5Ogt4Ra4tI
 PHUVrnLph6deD3knoct8WExjV4sQQwBKaUA4ahV0k3ltnnWpfD8GA3V5j4P8WdRp
 ul8RFOcAt7++DmLuSN2nW6avzz5D26IQtJ5/geJGEhLBBlYlP3F+KyAZBvpf8fHu
 W9K8yi98tzLNgHNz+HhM7OQsaWI7vdXZ+h8Rupbt9x4mpqUoYuwmRW0tEjpafIOy
 gx2MW4WkNg94etm+AXBMWbtccg3Q6wnDtZKDQ==
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp1.mailbox.org ([80.241.60.240])
 by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de
 [80.241.56.116]) (amavisd-new, port 10030)
 with ESMTP id F7uZaSVlSd1V; Thu, 27 Jul 2017 13:18:51 +0200 (CEST)
Date: Thu, 27 Jul 2017 13:18:31 +0200 (CEST)
From: "Herbert J. Skuhra" <herbert@mailbox.org>
To: freebsd-stable@freebsd.org
cc: emaste@FreeBSD.org
Subject: Re: r321601 causes make buildworld to fail on stable/11
In-Reply-To: <alpine.BSF.2.21.1707271129500.53090@mail.fig.ol.no>
Message-ID: <alpine.BSF.2.21.1707271310200.76130@bsd4all.net>
References: <alpine.BSF.2.21.1707271129500.53090@mail.fig.ol.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 8BIT
X-Content-Filtered-By: Mailman/MimeDel 2.1.23
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>;
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jul 2017 11:19:03 -0000

On Thu, 27 Jul 2017, Trond Endrestøl wrote:

> r321601 gives me these error messages on stable/11:
>
> /usr/src/usr.sbin/acpi/acpidump/acpi.c:1089:6: error: use of undeclared identifier 'ACPI_SRAT_TYPE_GIC_ITS_AFFINITY'; did you mean 'ACPI_SRAT_TYPE_GICC_AFFINITY'?
>    [ACPI_SRAT_TYPE_GIC_ITS_AFFINITY] = "GIC ITS",
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     ACPI_SRAT_TYPE_GICC_AFFINITY
> /usr/src/sys/contrib/dev/acpica/include/actbl1.h:1504:5: note: 'ACPI_SRAT_TYPE_GICC_AFFINITY' declared here
>    ACPI_SRAT_TYPE_GICC_AFFINITY        = 3,
>    ^
> /usr/src/usr.sbin/acpi/acpidump/acpi.c:1089:41: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
>    [ACPI_SRAT_TYPE_GIC_ITS_AFFINITY] = "GIC ITS",
>                                        ^~~~~~~~~
> /usr/src/usr.sbin/acpi/acpidump/acpi.c:1088:38: note: previous initialization is here
>    [ACPI_SRAT_TYPE_GICC_AFFINITY] = "GICC",
>                                     ^~~~~~
>
> Am I missing something? Am acpi.c missing something?

The following commit (or parts of it) is obviously missing on stable/11:

r319365 | jkim | 2017-06-01 02:01:19 +0200 (Thu, 01 Jun 2017) | 2 lines

Merge ACPICA 20170531.

The undeclared identifier is only available in HEAD:

     ACPI_SRAT_TYPE_GIC_ITS_AFFINITY     = 4,    /* ACPI 6.2 */

-- 
Herbert
From owner-freebsd-stable@freebsd.org  Thu Jul 27 11:23:29 2017
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BA89DC87EC
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Thu, 27 Jul 2017 11:23:29 +0000 (UTC)
 (envelope-from david@catwhisker.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 34B7572585
 for <freebsd-stable@freebsd.org>; Thu, 27 Jul 2017 11:23:29 +0000 (UTC)
 (envelope-from david@catwhisker.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 3405CDC87EB; Thu, 27 Jul 2017 11:23:29 +0000 (UTC)
Delivered-To: stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 339C8DC87EA
 for <stable@mailman.ysv.freebsd.org>; Thu, 27 Jul 2017 11:23:29 +0000 (UTC)
 (envelope-from david@catwhisker.org)
Received: from albert.catwhisker.org (mx.catwhisker.org [198.144.209.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E840F72583
 for <stable@freebsd.org>; Thu, 27 Jul 2017 11:23:27 +0000 (UTC)
 (envelope-from david@catwhisker.org)
Received: from albert.catwhisker.org (localhost [127.0.0.1])
 by albert.catwhisker.org (8.15.2/8.15.2) with ESMTP id v6RB2CYh060868
 for <stable@freebsd.org>; Thu, 27 Jul 2017 11:02:12 GMT
 (envelope-from david@albert.catwhisker.org)
Received: (from david@localhost)
 by albert.catwhisker.org (8.15.2/8.15.2/Submit) id v6RB2CbU060867
 for stable@freebsd.org; Thu, 27 Jul 2017 04:02:12 -0700 (PDT)
 (envelope-from david)
Date: Thu, 27 Jul 2017 04:02:12 -0700
From: David Wolfskill <david@catwhisker.org>
To: stable@freebsd.org
Subject: stable/11 src update r321515 -> r321613 fail in
 src/usr.sbin/acpi/acpidump/
Message-ID: <20170727110212.GU1183@albert.catwhisker.org>
Mail-Followup-To: David Wolfskill <david@catwhisker.org>,
	stable@freebsd.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="z25OBMfn/YQgmK1p"
Content-Disposition: inline
User-Agent: Mutt/1.8.3 (2017-05-23)
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>;
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jul 2017 11:23:29 -0000


--z25OBMfn/YQgmK1p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

freebeast(11.1-S)[1] uname -a
FreeBSD freebeast.catwhisker.org 11.1-STABLE FreeBSD 11.1-STABLE #409  r321=
515M/321515:1101501: Wed Jul 26 03:46:30 PDT 2017     root@freebeast.catwhi=
sker.org:/common/S1/obj/usr/src/sys/GENERIC  amd64
freebeast(11.1-S)[2]=20

freebeast(11.1-S)[2] svn info /usr/src
Path: /usr/src
Working Copy Root Path: /usr/src
URL: file:///svn/freebsd/src/base/stable/11
Relative URL: ^/stable/11
Repository Root: file:///svn/freebsd/src/base
Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
Revision: 321613
Node Kind: directory
Schedule: normal
Last Changed Author: mav
Last Changed Rev: 321613
Last Changed Date: 2017-07-27 03:29:29 -0700 (Thu, 27 Jul 2017)

freebeast(11.1-S)[3]=20

=2E..
--- all_subdir_usr.sbin ---
--- acpi.o ---
/usr/src/usr.sbin/acpi/acpidump/acpi.c:1089:6: error: use of undeclared ide=
ntifier 'ACPI_SRAT_TYPE_GIC_ITS_AFFINITY'; did you mean 'ACPI_SRAT_TYPE_GIC=
C_AFFINITY'?
    [ACPI_SRAT_TYPE_GIC_ITS_AFFINITY] =3D "GIC ITS",
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     ACPI_SRAT_TYPE_GICC_AFFINITY
/usr/src/sys/contrib/dev/acpica/include/actbl1.h:1504:5: note: 'ACPI_SRAT_T=
YPE_GICC_AFFINITY' declared here
    ACPI_SRAT_TYPE_GICC_AFFINITY        =3D 3,
    ^
=2E...


freebeast(11.1-S)[4] grep -wnr --exclude=3D./.svn\* ACPI_SRAT_TYPE_GIC_ITS_=
AFFINITY .
=2E/usr.sbin/acpi/acpidump/acpi.c:1089:    [ACPI_SRAT_TYPE_GIC_ITS_AFFINITY=
] =3D "GIC ITS",
freebeast(11.1-S)[5]=20


freebeast(11.1-S)[5] ^ACPI_SRAT_TYPE_GIC_ITS_AFFINITY^ACPI_SRAT_TYPE_GICC_A=
FFINITY
grep -wnr --exclude=3D./.svn\* ACPI_SRAT_TYPE_GICC_AFFINITY .
=2E/usr.sbin/acpi/acpidump/acpi.c:1088:    [ACPI_SRAT_TYPE_GICC_AFFINITY] =
=3D "GICC",
=2E/usr.sbin/acpi/acpidump/acpi.c:1120:   case ACPI_SRAT_TYPE_GICC_AFFINITY:
=2E/sys/contrib/dev/acpica/compiler/dttable2.c:1322:        case ACPI_SRAT_=
TYPE_GICC_AFFINITY:
=2E/sys/contrib/dev/acpica/include/actbl1.h:1504:    ACPI_SRAT_TYPE_GICC_AF=
FINITY        =3D 3,
=2E/sys/contrib/dev/acpica/common/dmtbdump.c:3496:        case ACPI_SRAT_TY=
PE_GICC_AFFINITY:
freebeast(11.1-S)[6]=20


Mind, I am using META_MODE, but I doubt that's at issue.

I will try the substitution clang suggests, then follow up.

Peace,
david
--=20
David H. Wolfskill				david@catwhisker.org
What kind of "investigation" would it be if it didn't "follow the money?"

See http://www.catwhisker.org/~david/publickey.gpg for my public key.

--z25OBMfn/YQgmK1p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJZecg0XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDQ0I3Q0VGOTE3QTgwMUY0MzA2NEQ3N0Ix
NTM5Q0M0MEEwNDlFRTE3AAoJEBU5zECgSe4XORUH/39bYWFh5eQIuISVLfHp+6ll
aR5Untp/d6T8sje718sH8OMFGxVRbGU6NRRC0FhX8kWTeqdhZwAhqbIxsmE8YE3I
q7yIftFIbDGbFUVTsL1T4vE55vlDn6ZLisVNPscZKNLCUKKd9+5iRD0qqvKGSBTo
r0ISJ/YSMWUAQ88fqf4sEENRbkQIzdNgtqyzoWEqCcdr3p19tN1gxsF3Y5b/FsR8
zSThBuMspO8WS2QDsUzwlIODcTle/lq7+HS5/iEM4t9AzA+iBfIxhHHVAu2DGZ/O
c9SddkSsVGeE5BJVz42ljTAwqcbT1J1AORwZWMbm4zralHsU5O7WUDiHij+ItKU=
=GJE7
-----END PGP SIGNATURE-----

--z25OBMfn/YQgmK1p--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.21.1707271301520.53090>