Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Feb 2019 20:57:37 +0000 (UTC)
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r344667 - stable/12/sbin/ipfw
Message-ID:  <201902282057.x1SKvbBH087896@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bdrewery
Date: Thu Feb 28 20:57:36 2019
New Revision: 344667
URL: https://svnweb.freebsd.org/changeset/base/344667

Log:
  MFC r343877,r343880:
  
    r343877:
      ipfw table list: Fix showing header outside of 'all'.
    r343880:
      Fix build of r343877
  
  Relnotes:	yes

Modified:
  stable/12/sbin/ipfw/tables.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sbin/ipfw/tables.c
==============================================================================
--- stable/12/sbin/ipfw/tables.c	Thu Feb 28 20:48:18 2019	(r344666)
+++ stable/12/sbin/ipfw/tables.c	Thu Feb 28 20:57:36 2019	(r344667)
@@ -282,13 +282,14 @@ ipfw_table_handler(int ac, char *av[])
 		}
 		break;
 	case TOK_LIST:
+		arg = is_all ? (void*)1 : NULL;
 		if (is_all == 0) {
 			ipfw_xtable_info i;
 			if ((error = table_get_info(&oh, &i)) != 0)
 				err(EX_OSERR, "failed to request table info");
-			table_show_one(&i, NULL);
+			table_show_one(&i, arg);
 		} else {
-			error = tables_foreach(table_show_one, NULL, 1);
+			error = tables_foreach(table_show_one, arg, 1);
 			if (error != 0)
 				err(EX_OSERR, "failed to request tables list");
 		}
@@ -821,13 +822,16 @@ table_show_one(ipfw_xtable_info *i, void *arg)
 {
 	ipfw_obj_header *oh;
 	int error;
+	int is_all;
 
+	is_all = arg == NULL ? 0 : 1;
+
 	if ((error = table_do_get_list(i, &oh)) != 0) {
 		err(EX_OSERR, "Error requesting table %s list", i->tablename);
 		return (error);
 	}
 
-	table_show_list(oh, 1);
+	table_show_list(oh, is_all);
 
 	free(oh);
 	return (0);	



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902282057.x1SKvbBH087896>