Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Jun 2013 02:23:00 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jmohacsi@bsd.hu
Subject:   ports/179825: [PATCH] graphics/gpicview: update to 0.2.3, add license, docs, NLS
Message-ID:  <20130622002308.F33683DC@hub.freebsd.org>
Resent-Message-ID: <201306220030.r5M0U01f059152@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179825
>Category:       ports
>Synopsis:       [PATCH] graphics/gpicview: update to 0.2.3, add license, docs, NLS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 22 00:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p8 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p8 FreeBSD 9.1-RELEASE-p8 #0: Tue Jun 18 15:25:28 UTC 2013
>Description:

- Update to 0.2.3
- Remove leading article from COMMENT
- Add license (GPLv2)
- Add desktop dependency
- Add DOCS NLS Option
- Trim WWW
- Trim pkg-plist

Port maintainer (jmohacsi@bsd.hu) is cc'd.

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: update, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130621203200-41583/

>Fix:

--- gpicview-0.2.3.patch begins here ---
diff -ruN /usr/ports/graphics/gpicview/Makefile ./Makefile
--- /usr/ports/graphics/gpicview/Makefile	2013-06-02 18:53:06.000000000 +0200
+++ ./Makefile	2013-06-21 22:30:03.000000000 +0200
@@ -2,28 +2,41 @@
 # $FreeBSD: head/graphics/gpicview/Makefile 316850 2013-04-29 22:27:05Z bapt $
 
 PORTNAME=	gpicview
-PORTVERSION=	0.2.1
-PORTREVISION=	4
+PORTVERSION=	0.2.3
 CATEGORIES=	graphics
-MASTER_SITES=	SF/lxde/GPicView%20%28image%20Viewer%29/GPicView%20${PORTVERSION}
+MASTER_SITES=	SF/lxde/GPicView%20%28image%20Viewer%29/GpicView%20${PORTVERSION}/
 
 MAINTAINER=	jmohacsi@bsd.hu
-COMMENT=	A Simple and Fast Image Viewer for X
+COMMENT=	Simple and Fast Image Viewer for X
 
+LICENSE=	GPLv2
+
+USES=		desktop-file-utils
 USE_GNOME=	gtk20
-USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	CPPFLAGS="-I${LOCALBASE}/include" \
 		LDFLAGS="-L${LOCALBASE}/lib"
+USE_GMAKE=	yes
+
+PORTDOCS=	AUTHORS
+
+OPTIONS_DEFINE=	DOCS NLS
+OPTIONS_SUB=	yes
+
+NLS_USES=	gettext
 
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MNLS}
-USES+=		gettext
-PLIST_SUB+=	NLS=""
-.else
-CONFIGURE_ARGS+=--disable-nls
-PLIST_SUB+=	NLS="@comment "
+post-patch:
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|src po|src|' \
+		${WRKSRC}/Makefile.in
+.endif
+
+post-install:
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/graphics/gpicview/distinfo ./distinfo
--- /usr/ports/graphics/gpicview/distinfo	2013-06-02 18:53:06.000000000 +0200
+++ ./distinfo	2013-06-21 22:23:44.000000000 +0200
@@ -1,2 +1,2 @@
-SHA256 (gpicview-0.2.1.tar.gz) = 4c85ef5affba0812b22426217871cc18366fa570e195dc43a5e0f17fbc005639
-SIZE (gpicview-0.2.1.tar.gz) = 422527
+SHA256 (gpicview-0.2.3.tar.gz) = 58dcdf9e1f29c38c9c5716215981c62c054282a765c57d9f7713232800f3bb99
+SIZE (gpicview-0.2.3.tar.gz) = 478447
diff -ruN /usr/ports/graphics/gpicview/pkg-descr ./pkg-descr
--- /usr/ports/graphics/gpicview/pkg-descr	2013-06-02 18:53:06.000000000 +0200
+++ ./pkg-descr	2013-06-22 02:15:28.000000000 +0200
@@ -9,4 +9,4 @@
     * Open source, licensed under GNU GPL
 
 
-WWW:	http://lxde.sourceforge.net/gpicview/
+WWW: http://lxde.sourceforge.net/gpicview/
diff -ruN /usr/ports/graphics/gpicview/pkg-plist ./pkg-plist
--- /usr/ports/graphics/gpicview/pkg-plist	2013-06-02 18:53:06.000000000 +0200
+++ ./pkg-plist	2013-06-21 22:27:56.000000000 +0200
@@ -1,17 +1,30 @@
 bin/gpicview
 share/applications/gpicview.desktop
+%%DATADIR%%/pixmaps/object-flip-horizontal.png
+%%DATADIR%%/pixmaps/object-flip-vertical.png
+%%DATADIR%%/pixmaps/object-rotate-left.png
+%%DATADIR%%/pixmaps/object-rotate-right.png
+%%DATADIR%%/ui/pref-dlg.ui
 %%NLS%%share/locale/af/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/ar/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/bg/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/bn/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/bn_IN/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/ca/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/cs/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/da/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/de/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/el/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/es/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/es_VE/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/et/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/eu/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/fa/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/fi/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/fr/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/frp/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/gl/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/he/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/hr/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/hu/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/id/LC_MESSAGES/gpicview.mo
@@ -31,7 +44,9 @@
 %%NLS%%share/locale/ru/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/sk/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/sl/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/sr/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/sv/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/th/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/tr/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/uk/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/ur/LC_MESSAGES/gpicview.mo
@@ -39,15 +54,14 @@
 %%NLS%%share/locale/vi/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/zh_CN/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/zh_TW/LC_MESSAGES/gpicview.mo
-%%DATADIR%%/pixmaps/object-rotate-right.png
-%%DATADIR%%/pixmaps/object-rotate-left.png
-%%DATADIR%%/pixmaps/object-flip-horizontal.png
-%%DATADIR%%/pixmaps/object-flip-vertical.png
-%%DATADIR%%/ui/pref-dlg.ui
 share/pixmaps/gpicview.png
-@dirrm %%DATADIR%%/pixmaps
-@dirrm %%DATADIR%%/ui
-@dirrmtry share/applications
-@dirrm %%DATADIR%%
 %%NLS%%@dirrmtry share/locale/ur_PK/LC_MESSAGES
 %%NLS%%@dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/frp
+%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/es_VE
+@dirrm %%DATADIR%%/ui
+@dirrm %%DATADIR%%/pixmaps
+@dirrm %%DATADIR%%
+@dirrmtry share/applications
--- gpicview-0.2.3.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130622002308.F33683DC>