Date: Mon, 07 Jan 2002 16:22:06 -0500 From: Tom Rhodes <darklogik@pittgoth.com> To: bmah@FreeBSD.ORG, FreeBSD doc list <freeBSD-doc@FreeBSD.ORG> Subject: Re: Close these pr's please (pr's and reasons listed) Message-ID: <3C3A117E.6090609@pittgoth.com> References: <200201071900.g07J0Xr17900@freefall.freebsd.org> <3C39FD3A.5000709@pittgoth.com> <200201072057.g07Kvro66040@bmah.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce A. Mah wrote: > If memory serves me right, Tom Rhodes wrote: > >>Pr : 20528 can be closed, please read my comments, as I have >>investigated this and found it to be fixed in later versions of FreeBSD >> >>Pr : 33371 has a patch, which I sent last week, I even obtained a reply >>stating that the pr submitter was happy with the patch and feel this pr >>may be closed as well >> >>Pr : 33259 just needs to be looked over, if Nik thinks no action needs >>to be taken than it can be closed >> >>Pr : 33645 is getting a lookover, I will check into it and possibly >>submit a patch later on today unless I hear an objection :) >> > > Tom, when you say "close these PRs", do you mean "change the state of > the PR to 'closed', no further action needed" or do you mean "commit > whatever patch is contained within the PR, and change the state of the > PR to 'closed'"? > > Usually, when we say "this PR can be closed", it takes on the former > meaning, usually because the problem doesn't exist anymore or the user > discovered the problem was with them or their system, not FreeBSD. > > A PR with a patch is almost always an implicit request for it to be > committed...frequently the problem is that these are competing with > other things for committer's time... > > Bruce. > > > > > Ok, thank you for pointing this out, I shall clarify this hehe: pr: 20528 should be closed, it has been pached since 4.4 Release and after my bit of research (speaking with the pr submitter and looking at the current manpage) everything seems fine. pr: 33371 has a patch, I would like commited, pr state changed to closed if you are happy with my work pr: 33259 should be looked over by someone with far more experiance than I have, and should decide what road needs to be taken Now I think we are on the same wavelink -- Tom (Darklogik) Rhodes www.Pittgoth.com Gothic Liberation Front www.FreeBSD.org The Power To Serve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C3A117E.6090609>