Date: Fri, 3 Apr 2015 10:00:02 -0700 From: Adrian Chadd <adrian@freebsd.org> To: hiren panchasara <hiren@strugglingcoder.info> Cc: Jack F Vogel <jfv@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org>, erj@freebsd.org, Jack Vogel <jfvogel@gmail.com>, Jason Wolfe <nitroboost@gmail.com> Subject: Re: Full 32bit flowid from igb(4) Message-ID: <CAJ-VmokzcHKHYanmwFgB_4d8CJKajs6G7gY11_J4nWGf3JAUkQ@mail.gmail.com> In-Reply-To: <20150403165411.GC72165@strugglingcoder.info> References: <20150323234214.GU53237@strugglingcoder.info> <CAFOYbc=f3OT85z50uqYEnBUkEej=8FRnRP8TpQuTStgqUEoDTA@mail.gmail.com> <20150324154931.GC53237@strugglingcoder.info> <CAJ-Vmo=ajfWokQ3bdu1Ww8kV3AdVwwsDpoS9y_%2Bywk%2BgcrbBvQ@mail.gmail.com> <20150330225945.GI10892@strugglingcoder.info> <CAJ-Vmom1tE6g=ta-DPLDF%2Bnp0GOpFYOXn=PkspaALfazz-n4Gg@mail.gmail.com> <20150331050628.GJ10892@strugglingcoder.info> <CAJ-VmokL1PnA=Nv0wKTWtY2f1RLCzW3GShOPQ0t=gd6B93kC4A@mail.gmail.com> <20150331170933.GK10892@strugglingcoder.info> <CAJ-Vmok19d4K0ucvsxc8kUmpv0e2L7CHkYjgNC56sg_wigC1cQ@mail.gmail.com> <20150403165411.GC72165@strugglingcoder.info>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 April 2015 at 09:54, hiren panchasara <hiren@strugglingcoder.info> wrote: > On 03/31/15 at 11:15P, Adrian Chadd wrote: >> Yeah, I think the right thing to do is: >> >> * If the descriptor says it's RSS, then use the flowid + rss type > So, if we have multiqueue, we do everything needed to get RSS > flowid/type. That means, with num_queues > 1 we can just expose those. > >> * else, set it to queue id and set the type to opaque. > > This part becomes irrelevant as it's a single queue case. Do we care > about setting flowid value/type in case of single queue? My whole point with not always setting it is that people may do things to /other/ parts of the driver and suddenly the RSS field isn't the RSS field anymore. Doubly so if you start playing with multiqueue + flowdirector on ixgbe. :) So I'd rather the driver be right and correct - checking if the field /is/ RSS and only setting the flowid+flowtype /if/ the value in that register is an RSS flowid, rather than setting it to whatever's there and hoping it's an RSS value. :) -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokzcHKHYanmwFgB_4d8CJKajs6G7gY11_J4nWGf3JAUkQ>