Date: Thu, 27 Nov 2014 07:21:14 +0300 From: Eygene Ryabinkin <rea@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: davidxu@FreeBSD.org, freebsd-threads@FreeBSD.org Subject: Re: [CFR][PATCH] Call proper signal handler from libthr for non-SA_SIGINFO case Message-ID: <t6N4RkaeaRObVTAlzRpdhmmcDSg@yxQcZffeD9XmruHr2cPBouRqdXo> In-Reply-To: <20141126221734.GM17068@kib.kiev.ua> References: <KBP9w7ztz0PP7uy58G1ODYb/voI@1d%2BaJAniZP50FCDdGj54nd51%2Bks> <20141120194925.GK17068@kib.kiev.ua> <ngq2VsHPChtgNNL/z%2BlRaAXEeTI@1d%2BaJAniZP50FCDdGj54nd51%2Bks> <20141121165658.GP17068@kib.kiev.ua> <cxMeZKcIhV0OesPiyimV3oGOays@W98LlNNy5PXu%2BS3VxPCL6cVmtdM> <20141121203227.GS17068@kib.kiev.ua> <jFEd1ENuyp8%2BKOBFhFLA4ucYsq0@btiPEv4nTmhOyKpuIO1ud%2BMiSV0> <20141126221734.GM17068@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--5I6of5zJg18YgZEa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thu, Nov 27, 2014 at 12:17:35AM +0200, Konstantin Belousov wrote: > On Thu, Nov 27, 2014 at 01:12:31AM +0300, Eygene Ryabinkin wrote: > >=20 > > Added them too. New patch is at > > http://codelabs.ru/fbsd/patches/libthr/11-CURRENT-fix-SIGINFO-process= ing-with-RESETHAND-v3.diff > >=20 >=20 > You went silent for several days, I committed the modified patch > earlier as r275120. >=20 > Thank you. Fine, thanks a lot! "td->td_ru.ru_nsignals++;" perhaps doesn't belong to the new function, but it is a matter of taste. By the way, shouldn't "PROC_LOCK_ASSERT(td->td_proc, MA_OWNED);" be also present single kern_sigprocmask() is called with SIGPROCMASK_PROC_LOCKED? --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --5I6of5zJg18YgZEa Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iL4EABEKAGYFAlR2prpfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PuvnAD+JCDxuJAOy4rdPwYJaUMBMnGL MlbJrJSFUIH1MgEaKKMA/iBw7JFiLvBtJ1jO14Y4quMy6j6ehRIyXVjVziA4+hVv =Hyos -----END PGP SIGNATURE----- --5I6of5zJg18YgZEa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?t6N4RkaeaRObVTAlzRpdhmmcDSg>