Date: Thu, 28 Feb 2019 13:51:17 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Kyle Evans <kevans@FreeBSD.org> Cc: Bryan Drewery <bdrewery@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344666 - head/tools/build/mk Message-ID: <5B91E4F8-C563-466D-A8FC-61A26F164109@gmail.com> In-Reply-To: <CACNAnaEFpXV4ooA8NY2-jJHKDKXHxc3SjcTPg6%2Bc0s7qk%2BNCQg@mail.gmail.com> References: <201902282048.x1SKmILE082786@repo.freebsd.org> <0EC04D65-721E-49F1-9755-7A8FDDE554DB@gmail.com> <CACNAnaEFpXV4ooA8NY2-jJHKDKXHxc3SjcTPg6%2Bc0s7qk%2BNCQg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 28, 2019, at 1:47 PM, Kyle Evans <kevans@FreeBSD.org> wrote: >=20 > On Thu, Feb 28, 2019 at 3:44 PM Enji Cooper <yaneurabeya@gmail.com> = wrote: >>=20 >>=20 >>> On Feb 28, 2019, at 12:48 PM, Bryan Drewery <bdrewery@FreeBSD.org> = wrote: >>>=20 >>> Author: bdrewery >>> Date: Thu Feb 28 20:48:18 2019 >>> New Revision: 344666 >>> URL: https://svnweb.freebsd.org/changeset/base/344666 >>>=20 >>> Log: >>> bsd.nls.mk isn't optional. >>>=20 >>> It is protected by MK_NLS. If it should really be optional then ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ To paraphrase Faith No More=E2=80=99s - = Epic: =E2=80=9Cwhat is =E2=80=98It=E2=80=99?" = ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > If we actually conditionally installed it, sure- it was only removed > because of r335011, so it would go through an install/remove dance > between installworld and delete-old on WITHOUT_NLS systems. Oh=E2=80=A6 you=E2=80=99re right. The commit message mislead me to think = that it was conditionally installed, but it=E2=80=99s actually always = installed. > If we're going to make it conditional on MK_NLS, it needs to actually > be conditional on MK_NLS the proper way along with an > s/.include/.sinclude/. This is what I was implying ;)=E2=80=A6 Cheers, -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5B91E4F8-C563-466D-A8FC-61A26F164109>