Date: Tue, 11 Mar 2003 12:25:05 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 26714 for review Message-ID: <200303112025.h2BKP5Cd074487@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=26714 Change 26714 by jhb@jhb_laptop on 2003/03/11 12:25:05 Axe the older and slower algo in witness_display_list() along with it's extra sanity check. Affected files ... .. //depot/projects/smpng/sys/kern/subr_witness.c#92 edit Differences ... ==== //depot/projects/smpng/sys/kern/subr_witness.c#92 (text+ko) ==== @@ -492,30 +492,11 @@ witness_display_list(void(*prnt)(const char *fmt, ...), struct witness_list *list) { -#if 1 struct witness *w; -#else - struct witness *w, *w1; - int found; -#endif STAILQ_FOREACH(w, list, w_typelist) { - if (w->w_file == NULL) + if (w->w_file == NULL || w->w_level > 0) continue; -#if 1 - if (w->w_level > 0) - continue; -#else - found = 0; - STAILQ_FOREACH(w1, list, w_typelist) { - if (isitmychild(w1, w)) { - found++; - break; - } - } - if (found) - continue; -#endif /* * This lock has no anscestors, display its descendants. */ @@ -557,19 +538,7 @@ if (w->w_file != NULL || w->w_refcount == 0) continue; prnt("%s\n", w->w_name); -#if 1 - w->w_displayed = 1; -#endif - } - -#if 1 - /* Extra check from Sanity Clause. */ - prnt("\nLocks which weren't displayed:\n"); - STAILQ_FOREACH(w, &w_all, w_list) { - if (w->w_displayed == 0) - witness_displaydescendants(prnt, w, 0); } -#endif } #endif /* DDB */ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303112025.h2BKP5Cd074487>