Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 31 Jan 2016 10:00:51 +0330
From:      mokhi <mokhi64@gmail.com>
To:        Warner Losh <imp@bsdimp.com>
Cc:        Ian Lepore <ian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>
Subject:   Re: thread-unsafety problems as spl*() ones are NOP
Message-ID:  <CAByVWPUqaWLEKqvXCepX4UZf6GYMW230VNJGC%2B6oN-gZ_NPvhQ@mail.gmail.com>
In-Reply-To: <37EC2460-9C4D-46D4-91A1-FA6CE7B0BFB1@bsdimp.com>
References:  <CAByVWPWuqdtZ-5p2%2BvGf4v%2BPjjCBkiTQSsZQ06vk-f=bx_TQrQ@mail.gmail.com> <CAByVWPWQJ1wP95S59SiWWBa0k9j2%2Bu1az-D04_V1voo99CxqCw@mail.gmail.com> <1454188175.32550.3.camel@freebsd.org> <CANCZdfrUjy=C0yjcW3QYbCHzYzAmrmC16GY2kpjKDoCBiCj_7Q@mail.gmail.com> <CAByVWPXu==acGjv54XCfawY7gmbB0SxrGrVff0f94QMqu6tf5A@mail.gmail.com> <37EC2460-9C4D-46D4-91A1-FA6CE7B0BFB1@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
@imp:
i exactly mean (Okay not so exact but very near ;D) what you said.
after analyzing kbd.c functions (eg, kbd_realloc_array()) i concluded
there are race conditions (and at  result in some places there are
un-protected data too)

i don't mean to blindly replace splXXX() with locks, but the places i
see race-conds.
Also i should say there are manythings i dunno well or i dont have
deep understanding of them and that's why im here to ask (ie what
special condition Giant-Lock makes here [i should care about] and what
is MPSAFE basically)
i'd happy if you answer me those question too :D

Regards, Mokhi.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAByVWPUqaWLEKqvXCepX4UZf6GYMW230VNJGC%2B6oN-gZ_NPvhQ>