Date: Sun, 27 Jul 2014 11:19:21 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192161] New: ports-mgmt/portlint: 100-character patchname rule is buggy Message-ID: <bug-192161-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192161 Bug ID: 192161 Summary: ports-mgmt/portlint: 100-character patchname rule is buggy Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: marino@FreeBSD.org Revision 361618 added this rule among others: * Check to make sure patch file names contain no more than 100 characters. I believe the rule wants the filename of the patch to be less than 100 characters, but the check is counting the entire path. For example, > cd /usr/ports/deskutils/cairo-dock-plugins > portlint (only warnings seen) but then when the ports tree is in a non-standard location: root@Niner:~ # cd /home/marino/svnhub/freebsd-ports/deskutils/cairo-dock-plugins/ root@Niner:/home/marino/svnhub/freebsd-ports/deskutils/cairo-dock-plugins # portlint WARN: Makefile: TERMINAL appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE. WARN: Makefile: Consider adding support for a NLS knob to conditionally disablegettext support. WARN: Makefile: Consider defining LICENSE. FATAL: /usr/home/marino/svnhub/freebsd-ports/deskutils/cairo-dock-plugins/files/ patch-Dbus__interfaces__vala__CMakeLists.txt: make sure patch file names contain no more than 100 characters. 1 fatal error and 3 warnings found. So that's why I think the rule is looking at the length of the entire path, and not the length of just the filename of the patch. I've seen this on a few ports now. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192161-13>