Date: Wed, 12 Dec 2018 12:33:17 +0000 (UTC) From: Hans Petter Selasky <hselasky@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r341952 - stable/11/sys/dev/mlx5/mlx5_ib Message-ID: <201812121233.wBCCXHLP086633@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: hselasky Date: Wed Dec 12 12:33:17 2018 New Revision: 341952 URL: https://svnweb.freebsd.org/changeset/base/341952 Log: MFC r341569: mlx5ib: Fix null pointer dereference in mlx5_ib_create_srq Although "create_srq_user" does overwrite "in.pas" on some paths, it also contains at least one feasible path which does not overwrite it. Sponsored by: Mellanox Technologies Modified: stable/11/sys/dev/mlx5/mlx5_ib/mlx5_ib_srq.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/dev/mlx5/mlx5_ib/mlx5_ib_srq.c ============================================================================== --- stable/11/sys/dev/mlx5/mlx5_ib/mlx5_ib_srq.c Wed Dec 12 12:33:12 2018 (r341951) +++ stable/11/sys/dev/mlx5/mlx5_ib/mlx5_ib_srq.c Wed Dec 12 12:33:17 2018 (r341952) @@ -287,7 +287,7 @@ struct ib_srq *mlx5_ib_create_srq(struct ib_pd *pd, else err = create_srq_kernel(dev, srq, &in, buf_size); - if (err) { + if (err || !in.pas) { mlx5_ib_warn(dev, "create srq %s failed, err %d\n", pd->uobject ? "user" : "kernel", err); goto err_srq;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812121233.wBCCXHLP086633>