Date: Fri, 26 Mar 2004 13:27:15 -0500 From: Garance A Drosehn <gad@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/pkill pkill.c Message-ID: <p06020492bc8a2491cfed@[128.113.24.47]> In-Reply-To: <Pine.NEB.3.96L.1040326131052.79234E-100000@fledge.watson.org> References: <Pine.NEB.3.96L.1040326131052.79234E-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 1:11 PM -0500 3/26/04, Robert Watson wrote: >On Fri, 26 Mar 2004, Garance A Drosehn wrote: > >> Modified files: >> usr.bin/pkill pkill.c >> Log: > > Switch to checking P_KTHREAD instead of P_SYSTEM when > > deciding what "system processes" to always ignore. > >Either our definition or my understanding of P_KTHREAD vs >P_SYSTEM is weak. P_SYSTEM seems to include init, and >P_KTHREAD seems to mean things that really are kprocs, but >there was some recent discussion of the details of this on >arch@ with regard to whether signals should be delivered to >things that are arguably kernel threads or processes. It would not surprise me if P_KTHREAD is not the most correct check for me to make here, but in my debugging it sure seems like using P_SYSTEM results in some processes getting skipped that I do not expect to be skipped. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p06020492bc8a2491cfed>