Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Aug 2008 09:35:30 -0700
From:      Julian Elischer <julian@elischer.org>
To:        Marko Zec <zec@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 147532 for review
Message-ID:  <48A701D2.5050004@elischer.org>
In-Reply-To: <200808161256.m7GCuZS9012842@repoman.freebsd.org>
References:  <200808161256.m7GCuZS9012842@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Marko Zec wrote:
> http://perforce.freebsd.org/chv.cgi?CH=147532
> 
> Change 147532 by zec@zec_tpx32 on 2008/08/16 12:56:28
> 
> 	Looks like I was a bit hasty with change 147531.  ip_newid()
> 	is an inline defined in ip_var.h, so whereever it is used in
> 	the code, definitions from sys/vimage.h are required.  So,
> 	instead of reverting back to pre-147531, #include sys/vimage.h
> 	once from netinet/ip_var.h, instead of having it in included
> 	individually from a multitude of affected .c files.
> 	of .
> 

I was considering doing this, or possibly changing ip_newid()
to not need it.

> Affected files ...
> 
> .. //depot/projects/vimage-commit2/src/sys/netinet/ip_var.h#3 edit
> 
> Differences ...
> 
> ==== //depot/projects/vimage-commit2/src/sys/netinet/ip_var.h#3 (text+ko) ====
> 
> @@ -34,6 +34,7 @@
>  #define	_NETINET_IP_VAR_H_
>  
>  #include <sys/queue.h>
> +#include <sys/vimage.h>
>  
>  /*
>   * Overlay for ip header used by other protocols (tcp, udp).




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48A701D2.5050004>