Date: Sat, 8 May 2010 23:01:47 +0000 (UTC) From: Alan Cox <alc@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r207805 - head/sys/kern Message-ID: <201005082301.o48N1l0p054509@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: alc Date: Sat May 8 23:01:47 2010 New Revision: 207805 URL: http://svn.freebsd.org/changeset/base/207805 Log: Update a comment: It no longer makes sense to talk about the page queues lock here. Modified: head/sys/kern/sys_pipe.c Modified: head/sys/kern/sys_pipe.c ============================================================================== --- head/sys/kern/sys_pipe.c Sat May 8 22:25:37 2010 (r207804) +++ head/sys/kern/sys_pipe.c Sat May 8 23:01:47 2010 (r207805) @@ -767,13 +767,10 @@ pipe_build_write_buffer(wpipe, uio) return (EFAULT); for (i = 0; addr < endaddr; addr += PAGE_SIZE, i++) { /* - * vm_fault_quick() can sleep. Consequently, - * vm_page_lock_queue() and vm_page_unlock_queue() - * should not be performed outside of this loop. + * vm_fault_quick() can sleep. */ race: if (vm_fault_quick((caddr_t)addr, VM_PROT_READ) < 0) { - for (j = 0; j < i; j++) { vm_page_lock(wpipe->pipe_map.ms[j]); vm_page_unhold(wpipe->pipe_map.ms[j]);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005082301.o48N1l0p054509>