Date: Thu, 12 Nov 2015 15:18:07 +0000 From: "Pieper, Jeffrey E" <jeffrey.e.pieper@intel.com> To: Steven Hartland <steven@multiplay.co.uk>, Ryan Stone <rysto32@gmail.com> Cc: Jack F Vogel <jfv@freebsd.org>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: RE: Intel XL710 broken link down detection? Message-ID: <2A35EA60C3C77D438915767F458D65688080C4A8@ORSMSX111.amr.corp.intel.com> In-Reply-To: <56446159.3080405@multiplay.co.uk> References: <564357E0.1050002@freebsd.org> <56436A5F.4020102@multiplay.co.uk> <CAFMmRNwuc4N%2B6TSCFuknbfYZnMzXuuunFbyeGfyaOzYWxgWfaA@mail.gmail.com> <56446159.3080405@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
We already have a fix in place that will be committed for review shortly.=20 Thanks, Jeff -----Original Message----- From: owner-freebsd-net@freebsd.org [mailto:owner-freebsd-net@freebsd.org] = On Behalf Of Steven Hartland Sent: Thursday, November 12, 2015 1:52 AM To: Ryan Stone <rysto32@gmail.com> Cc: Jack F Vogel <jfv@freebsd.org>; freebsd-net@freebsd.org Subject: Re: Intel XL710 broken link down detection? Yes this works but a better way IMO would be to invert the bits we want: https://people.freebsd.org/~smh/ixl_int_init.patch If there are no objections then I'll commit this later today. Also just fixed the debug sysctls from causing panics when compiled with=20 INVARIANTS see: https://svnweb.freebsd.org/base?view=3Drevision&revision=3D290708 Regards Steve On 11/11/2015 16:31, Ryan Stone wrote: > On Wed, Nov 11, 2015 at 11:18 AM, Steven Hartland=20 > <steven@multiplay.co.uk <mailto:steven@multiplay.co.uk>> wrote: > > Comparing this to the Linux driver which does detect the link down > I've discovered it actually polls the link status by default in > its watchdog. > > Disabling this with "ethtool --set-priv-flags eth1 LinkPolling > off" and the Linux driver also fails to detect link down. > > So this seems like a firmware or even hardware bug where it should > be reporting down events and the Linux driver has been updated to > workaround the problem? > > > No, apparently the Linux devs just didn't read the datasheet closely=20 > enough (and presumably the FreeBSD driver copied the mistake). There=20 > is a mask of interrupt causes that works backwards from how one would=20 > expect; you mask out events that you *don't* want rather than events=20 > that you do want. Both the Linux and FreeBSD drivers pass a mask of=20 > events that they want interrupts for (the only reason why it appears=20 > to work on link up is that the the AN Completed event fires when link=20 > is up, as far as I can tell). Try the following patch: > > https://people.freebsd.org/~rstone/patches/ixl_link_int.diff=20 > <https://people.freebsd.org/%7Erstone/patches/ixl_link_int.diff>; > _______________________________________________ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2A35EA60C3C77D438915767F458D65688080C4A8>