Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Nov 2008 14:49:49 +0100
From:      =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To:        Sean Farley <scf@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r185237 - head/lib/libutil
Message-ID:  <86wsetfd36.fsf@ds4.des.no>
In-Reply-To: <200811232326.mANNQCLp067323@svn.freebsd.org> (Sean Farley's message of "Sun, 23 Nov 2008 23:26:12 %2B0000 (UTC)")
References:  <200811232326.mANNQCLp067323@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Sean Farley <scf@FreeBSD.org> writes:
> Log:
>   Fixed style issues with variable ordering and naming, spacing and
>   parentheses.
>=20=20=20
>   Fixed alignment issue in gr_dup() in its assignment of gr_mem using a
>   struct to force alignment without performing alignment mathematics.  Th=
is
>   was noticed recently with libutil was built with WARNS=3D6 on platform =
such
>   as sparc64.
>=20=20=20
>   Added checks to gr_dup(), gr_equal() and gr_make() to prevent segfaults
>   when examining struct group's with the struct members pointing to NULL'=
s.
>=20=20=20
>   With fix of alignment issue, restore WARNS?=3D6.

Good work, thank you!

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86wsetfd36.fsf>