Date: Sun, 03 Jul 2005 01:10:44 -0000 From: Andrey Chernov <ache@nagual.pp.ru> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_generic.c Message-ID: <20050125112614.GD29791@nagual.pp.ru> In-Reply-To: <81636.1106651373@critter.freebsd.dk> References: <20050125110648.GB29791@nagual.pp.ru> <81636.1106651373@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 25, 2005 at 12:09:33PM +0100, Poul-Henning Kamp wrote: > >I.e. look at ERRORS section list and inspect each errno returning broken > >by preliminary zero bytes check. > > That's another check we didn't do before to the resid==0 handling before. > > Now, I'm going to killfile this subject until you come up with code which > real-life code which breaks because of this, OK ? I just show you the way of finding such cases, I already say I don't have much time to dig out real one. It is you who must prove that your addition not change anything or not violate POSIX. Because there is strong suspicion that you violates POSIX quote I already mention. I.e. look in the fo_read() chain and see which errors are skipped now. Even if you don't find such ones, it may simple mean that resid==0 check was placed preliminary in our old code, and it is old code which needs to be fixed. -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050125112614.GD29791>